Skip to content

Commit

Permalink
debian: Avoid -Wformat-zero-length warnings.
Browse files Browse the repository at this point in the history
Debian puts an extra "-Wformat" in the CFLAGS following OVS's own
"-Wformat -Wno-format-zero-length", which therefore overrides
-Wno-format-zero-length, so this commit adds an extra
-Wno-format-zero-length to avoid those false positives.

Signed-off-by: Ben Pfaff <[email protected]>
Acked-by: Justin Pettit <[email protected]>
  • Loading branch information
blp committed Jul 22, 2014
1 parent 13a233f commit 346f589
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions debian/rules
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ endif
buildflags := $(shell if dpkg-buildflags --export=configure >/dev/null 2>&1; \
then dpkg-buildflags --export=configure; fi)

# dpkg-buildflags tends to turn on -Wformat, which is admirable, but
# the -Wformat-zero-length subset of that option triggers a couple of
# false positives in Open vSwitch so turn it right back off again.
# (We do this in configure.ac also, but the Debian buildflags override
# those.)
buildflags := $(patsubst -Wformat,-Wformat -Wno-format-zero-length,$(buildflags))

configure: configure-stamp
configure-stamp:
dh_testdir
Expand Down

0 comments on commit 346f589

Please sign in to comment.