MDL-62709 core_message: fix for silently ignored errors in task

robjoyce · Jun 14, 2018 · 8791c50 · 8791c50
1 parent 50e48a8
commit 8791c50
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/message/classes/task/migrate_message_data.php b/message/classes/task/migrate_message_data.php
@@ -90,10 +90,10 @@ public function execute() {
                             $this->migrate_data($userid, $otheruserid);
                             $transaction->allow_commit();
                         } catch (\Throwable $e) {
-                            $updatepreference = false;
+                            throw $e;
+                        } finally {
+                            $lock->release();
                         }
-
-                        $lock->release();
                     } else {
                         // Couldn't get a lock, move on to next user but make sure we don't update user preference so
                         // we still try again.