MDL-49346 ratings: ratingarea should be a required parameter

robjoyce · Mar 6, 2015 · 9502a19 · 9502a19
1 parent b90f98d
commit 9502a19
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/rating/index.php b/rating/index.php
@@ -28,7 +28,7 @@
 
 $contextid  = required_param('contextid', PARAM_INT);
 $component  = required_param('component', PARAM_COMPONENT);
-$ratingarea = optional_param('ratingarea', null, PARAM_AREA);
+$ratingarea = required_param('ratingarea', PARAM_AREA);
 $itemid     = required_param('itemid', PARAM_INT);
 $scaleid    = required_param('scaleid', PARAM_INT);
 $sort       = optional_param('sort', '', PARAM_ALPHA);
@@ -39,11 +39,9 @@
 
 $url = new moodle_url('/rating/index.php', array('contextid' => $contextid,
                                                  'component' => $component,
+                                                 'ratingarea' => $ratingarea,
                                                  'itemid' => $itemid,
                                                  'scaleid' => $scaleid));
-if (!empty($ratingarea)) {
-    $url->param('ratingarea', $ratingarea);
-}
 if (!empty($sort)) {
     $url->param('sort', $sort);
 }