MDL-49985 core_course: revert commit belonging to MDL-18309

This reverts commit 6601690.

This commit was adding the 'returnurl' param unnecessarily to the
course links in the navigation block, causing a lot of long URLs
to be created.

blocks/navigation/yui/build/moodle-block_navigation-navigation/moodle-block_navigation-navigation-debug.js

@@ -634,8 +634,7 @@ BRANCH.prototype = {
             id : this.get('key'),
             type : this.get('type'),
             sesskey : M.cfg.sesskey,
-            instance : this.get('tree').get('instance'),
-            returnurl : location.href
+            instance : this.get('tree').get('instance')
         };
 
         var ajaxfile = '/lib/ajax/getnavbranch.php';

blocks/navigation/yui/build/moodle-block_navigation-navigation/moodle-block_navigation-navigation.js

@@ -632,8 +632,7 @@ BRANCH.prototype = {
             id : this.get('key'),
             type : this.get('type'),
             sesskey : M.cfg.sesskey,
-            instance : this.get('tree').get('instance'),
-            returnurl : location.href
+            instance : this.get('tree').get('instance')
         };
 
         var ajaxfile = '/lib/ajax/getnavbranch.php';

blocks/navigation/yui/src/navigation/js/navigation.js

@@ -632,8 +632,7 @@ BRANCH.prototype = {
             id : this.get('key'),
             type : this.get('type'),
             sesskey : M.cfg.sesskey,
-            instance : this.get('tree').get('instance'),
-            returnurl : location.href
+            instance : this.get('tree').get('instance')
         };
 
         var ajaxfile = '/lib/ajax/getnavbranch.php';

course/category.ajax.php

@@ -29,14 +29,11 @@
 
 require_once(dirname(__dir__) . '/config.php');
 
-$returnurl = optional_param('returnurl', 0, PARAM_LOCALURL);
-
 if ($CFG->forcelogin) {
     require_login();
 }
 
 $PAGE->set_context(context_system::instance());
 $courserenderer = $PAGE->get_renderer('core', 'course');
-$courserenderer->returnurl = $returnurl;
 
 echo json_encode($courserenderer->coursecat_ajax());

course/index.php

@@ -44,7 +44,6 @@
 
 $PAGE->set_pagelayout('coursecategory');
 $courserenderer = $PAGE->get_renderer('core', 'course');
-$courserenderer->returnurl = $PAGE->url;
 
 if ($CFG->forcelogin) {
     require_login();

course/renderer.php

@@ -49,9 +49,6 @@ class core_course_renderer extends plugin_renderer_base {
      */
     protected $strings;
 
-    /** @var moodle_url|null stores page where to return to from the enrolment page */
-    public $returnurl;
-
     /**
      * Override the constructor so that we can initialise the string cache
      *
@@ -1210,8 +1207,7 @@ protected function coursecat_coursebox(coursecat_helper $chelper, $course, $addi
 
         // course name
         $coursename = $chelper->get_course_formatted_name($course);
-        $coursenamelink = html_writer::link(new moodle_url('/course/view.php',
-                                                           array('id' => $course->id, 'returnurl' => $this->returnurl)),
+        $coursenamelink = html_writer::link(new moodle_url('/course/view.php', array('id' => $course->id)),
                                             $coursename, array('class' => $course->visible ? '' : 'dimmed'));
         $content .= html_writer::tag($nametag, $coursenamelink, array('class' => 'coursename'));
         // If we display course in collapsed form but the course has summary or course contacts, display the link to the info page.

course/view.php

@@ -19,7 +19,6 @@
     $switchrole  = optional_param('switchrole',-1, PARAM_INT); // Deprecated, use course/switchrole.php instead.
     $modchooser  = optional_param('modchooser', -1, PARAM_BOOL);
     $return      = optional_param('return', 0, PARAM_LOCALURL);
-    $returnurl   = optional_param('returnurl', 0, PARAM_LOCALURL);
 
     $params = array();
     if (!empty($name)) {
@@ -43,9 +42,6 @@
     if ($section) {
         $urlparams['section'] = $section;
     }
-    if ($returnurl) {
-        $urlparams['returnurl'] = $returnurl;
-    }
 
     $PAGE->set_url('/course/view.php', $urlparams); // Defined here to avoid notices on errors etc
 

course/yui/build/moodle-course-categoryexpander/moodle-course-categoryexpander-debug.js

@@ -181,8 +181,7 @@ NS._toggle_category_expansion = function(e) {
             categoryid: categoryid,
             depth: depth,
             showcourses: categorynode.getData('showcourses'),
-            type: TYPE_CATEGORY,
-            returnurl: location.href
+            type: TYPE_CATEGORY
         }
     });
 };