Skip to content

Commit

Permalink
fix structs with field name of 'Bytes'
Browse files Browse the repository at this point in the history
(it conflict with a method of the same name that is generated for
all such structs)
  • Loading branch information
BurntSushi committed Mar 29, 2016
1 parent 5d9015c commit b3a96fa
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
3 changes: 2 additions & 1 deletion auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ func readAuthority(hostname, display string) (
return "", nil, err
}

addrmatch := (family == familyWild) || (family == familyLocal && addr == hostname)
addrmatch := (family == familyWild) ||
(family == familyLocal && addr == hostname)
dispmatch := (disp == "") || (disp == display)

if addrmatch && dispmatch {
Expand Down
10 changes: 5 additions & 5 deletions res/res.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ func ResourceIdSpecListBytes(buf []byte, list []ResourceIdSpec) int {

type ResourceSizeSpec struct {
Spec ResourceIdSpec
Bytes uint32
Bytes_ uint32
RefCount uint32
UseCount uint32
}
Expand All @@ -295,7 +295,7 @@ func ResourceSizeSpecRead(buf []byte, v *ResourceSizeSpec) int {
v.Spec = ResourceIdSpec{}
b += ResourceIdSpecRead(buf[b:], &v.Spec)

v.Bytes = xgb.Get32(buf[b:])
v.Bytes_ = xgb.Get32(buf[b:])
b += 4

v.RefCount = xgb.Get32(buf[b:])
Expand Down Expand Up @@ -328,7 +328,7 @@ func (v ResourceSizeSpec) Bytes() []byte {
b += len(structBytes)
}

xgb.Put32(buf[b:], v.Bytes)
xgb.Put32(buf[b:], v.Bytes_)
b += 4

xgb.Put32(buf[b:], v.RefCount)
Expand Down Expand Up @@ -641,7 +641,7 @@ type QueryClientPixmapBytesReply struct {
Sequence uint16 // sequence number of the request for this reply
Length uint32 // number of bytes in this reply
// padding: 1 bytes
Bytes uint32
Bytes_ uint32
BytesOverflow uint32
}

Expand Down Expand Up @@ -670,7 +670,7 @@ func queryClientPixmapBytesReply(buf []byte) *QueryClientPixmapBytesReply {
v.Length = xgb.Get32(buf[b:]) // 4-byte units
b += 4

v.Bytes = xgb.Get32(buf[b:])
v.Bytes_ = xgb.Get32(buf[b:])
b += 4

v.BytesOverflow = xgb.Get32(buf[b:])
Expand Down
2 changes: 1 addition & 1 deletion xgb.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type Conn struct {
seqChan chan uint16
reqChan chan *request
closing chan chan struct{}

// ExtLock is a lock used whenever new extensions are initialized.
// It should not be used. It is exported for use in the extension
// sub-packages.
Expand Down
3 changes: 3 additions & 0 deletions xgbgen/field.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ func (f *SingleField) Initialize(p *Protocol) {
}

func (f *SingleField) SrcName() string {
if f.srcName == "Bytes" {
return "Bytes_"
}
return f.srcName
}

Expand Down

0 comments on commit b3a96fa

Please sign in to comment.