-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to bullet physics engine #340
base: devel
Are you sure you want to change the base?
Conversation
a755e70
to
5b975e4
Compare
5b975e4
to
3505412
Compare
The new release gazebosim/gz-physics#255 contains the bullet physics backend, maybe now this PR could be finalized. Checking if CI succeeds. |
3505412
to
2968e83
Compare
Tests are failing with the following:
I guess I have to align the Physics system with upstream. When I first opened this PR, the test was passing. |
This PR depends on gazebosim/gz-sim#690 that is part of Ignition Edifice 5.1. However, as tracked in #319, that PR causes a significant performance drop when contacts are involved (e.g. in the panda manipulation example). This means that our vendored physics system has to revert that PR for the moment, and bullet support has to be postponed until the origin of the slow-down is found. |
2968e83
to
c6710d4
Compare
I opened gazebosim/gz-physics#273 to track the problem occurring in the tests. |
c6710d4
to
6be6024
Compare
3796e47
to
77819be
Compare
84ce929
to
0d1909e
Compare
The bullet engine does work with simple simulations like those included in the test (at least locally in a conda-based environment that has a recent bullet version). However, more complex simulations like the manipulation example do not work properly, the panda get smashed in the beginning (maybe due to the PIDs?). Furthermore, this PR updates the Physics system with a feature that has been reverted from upstream that causes a performance regression when contacts are involved (#319). |
0d1909e
to
2e47440
Compare
Related to the upcoming bullet support, more info in April's 2021 Community Meeting.
This PR is very WIP because the new bullet plugin has not yet been released nor finalized.
However, a while ago I wanted to play with it 😃
It needs a custom branch of ign-physics that is not currently enabled in CI.
TODO: