Skip to content

Commit

Permalink
Add sig-testing OWNERS_ALIASES
Browse files Browse the repository at this point in the history
follow the sig-foo-{reviewers,approvers} convention
- rename test-infra-maintainers to sig-testing-approvers
- copy sig-testing-approvers to sig-testing-reviewers
- remove inviduals in test/OWNERS in favor of new aliases

as a result
- rmmh gets test/ approver privileges
- spiffxp gets hack/jenkins/ approver privileges
  • Loading branch information
spiffxp committed Jul 25, 2017
1 parent 12cc642 commit 7e63bf5
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
9 changes: 8 additions & 1 deletion OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,17 @@ aliases:
- smarterclayton
- soltysh
- sttts
test-infra-maintainers:
sig-testing-reviewers:
- fejta
- ixdy
- rmmh
- spiffxp
- spxtr
sig-testing-approvers:
- fejta
- ixdy
- rmmh
- spiffxp
- spxtr
sig-node-reviewers:
- Random-Liu
Expand Down
4 changes: 2 additions & 2 deletions hack/jenkins/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
approvers:
- test-infra-maintainers
- sig-testing-approvers
reviewers:
- test-infra-maintainers
- sig-testing-reviewers
11 changes: 2 additions & 9 deletions test/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@ reviewers:
- enisoc
- erictune
- fabianofranz # for test/e2e/kubectl.go
- fejta
- foxish # for test/e2e/network-partition.go
- gmarek
- ixdy
- janetkuo
- kow3ns # for test/e2e/statefulset.go
- krousey
Expand All @@ -17,12 +15,10 @@ reviewers:
- mikedanese
- ncdc
- pwittrock # for test/e2e/kubectl.go
- rmmh
- saad-ali
- smarterclayton
- soltysh
- spiffxp
- spxtr
- sig-testing-reviewers
- sttts
- zmerlynn
approvers:
Expand All @@ -32,10 +28,8 @@ approvers:
- eparis
- erictune
- fabianofranz # for test/e2e/kubectl.go
- fejta
- foxish # for test/e2e/network-partition.go
- gmarek
- ixdy
- janetkuo
- kow3ns # for test/e2e/statefulset.go
- krousey
Expand All @@ -46,9 +40,8 @@ approvers:
- ncdc
- pwittrock # for test/e2e/kubectl.go
- saad-ali
- sig-testing-approvers
- smarterclayton
- soltysh
- spiffxp
- spxtr
- sttts
- zmerlynn

0 comments on commit 7e63bf5

Please sign in to comment.