MDL-28945 course_reports: Fixed up pagination issue

roddle · Oct 19, 2011 · 7229f23 · 7229f23
1 parent 9a23f94
commit 7229f23
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/course/report/completion/index.php b/course/report/completion/index.php
@@ -274,9 +274,13 @@ function csv_quote($value) {
     $pagingbar .= get_string('page').': ';
 
     $sistrings = array();
-    $sistrings[] = $sifirst != 'all' ? "sifirst={$sifirst}" : null;
-    $sistrings[] = $silast != 'all' ? "silast={$silast}" : null;
-    $sistring = !empty($sistrings) ? implode('&amp;', $sistrings) : '';
+    if ($sifirst != 'all') {
+        $sistrings[] =  "sifirst={$sifirst}";
+    }
+    if ($silast != 'all') {
+        $sistrings[] =  "silast={$silast}";
+    }
+    $sistring = !empty($sistrings) ? '&amp;'.implode('&amp;', $sistrings) : '';
 
     // Display previous link
     if ($start > 0) {

diff --git a/course/report/progress/index.php b/course/report/progress/index.php
@@ -206,9 +206,13 @@ function csv_quote($value) {
     $pagingbar .= get_string('page').': ';
 
     $sistrings = array();
-    $sistrings[] = $sifirst != 'all' ? "sifirst={$sifirst}" : null;
-    $sistrings[] = $silast != 'all' ? "silast={$silast}" : null;
-    $sistring = !empty($sistrings) ? implode('&amp;', $sistrings) : '';
+    if ($sifirst != 'all') {
+        $sistrings[] =  "sifirst={$sifirst}";
+    }
+    if ($silast != 'all') {
+        $sistrings[] =  "silast={$silast}";
+    }
+    $sistring = !empty($sistrings) ? '&amp;'.implode('&amp;', $sistrings) : '';
 
     // Display previous link
     if ($start > 0) {