MDL-43908 mod_assign: Prevent notifications for unavailable assignments

Signed-off-by: Tony Butler <[email protected]>
roddle · Jul 24, 2014 · c681f7a · c681f7a
1 parent ccd6839
commit c681f7a
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php
@@ -5971,7 +5971,16 @@ public function add_grade_form_elements(MoodleQuickForm $mform, stdClass $data,
             }
         }
         $mform->addElement('selectyesno', 'sendstudentnotifications', get_string('sendstudentnotifications', 'assign'));
-        $mform->setDefault('sendstudentnotifications', $this->get_instance()->sendstudentnotifications);
+        // Get assignment visibility information for student.
+        $modinfo = get_fast_modinfo($settings->course, $userid);
+        $cm = $modinfo->get_cm($this->get_course_module()->id);
+        // Don't allow notification to be sent if student can't access assignment.
+        if (!$cm->uservisible) {
+            $mform->setDefault('sendstudentnotifications', 0);
+            $mform->freeze('sendstudentnotifications');
+        } else {
+            $mform->setDefault('sendstudentnotifications', $this->get_instance()->sendstudentnotifications);
+        }
 
         $mform->addElement('hidden', 'action', 'submitgrade');
         $mform->setType('action', PARAM_ALPHA);