Remove mutable default parameter in init_inference() (microsoft#2540)

A mutable default value is dangerous because editing it will change the value for all future calls to the function. The value is itself edited later in the function, so this problem will likely be encountered sooner or later. Co-authored-by: Michael Wyatt <[email protected]>
rohithkrn · Nov 23, 2022 · 4abf637 · 4abf637
1 parent c5ee27f
commit 4abf637
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/deepspeed/__init__.py b/deepspeed/__init__.py
@@ -230,7 +230,7 @@ def default_inference_config():
     return DeepSpeedInferenceConfig().dict()
 
 
-def init_inference(model, config={}, **kwargs):
+def init_inference(model, config=None, **kwargs):
     """Initialize the DeepSpeed InferenceEngine.
 
     Description: all four cases are valid and supported in DS init_inference() API.
@@ -285,6 +285,8 @@ def init_inference(model, config={}, **kwargs):
              ranks=[0])
 
     # Load config_dict from config first
+    if config is None:
+        config = {}
     if isinstance(config, str):
         with open(config, "r") as f:
             config_dict = json.load(f)