Make nvd3 refresh smoother. (apache#1618)

rohithreddi · Nov 18, 2016 · e546746 · e546746
1 parent ab5a410
commit e546746
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/superset/assets/javascripts/explore/explore.jsx b/superset/assets/javascripts/explore/explore.jsx
@@ -73,6 +73,7 @@ function query(forceUpdate, pushState) {
     // update the url after prepForm() fix the field ids
     history.pushState({}, document.title, slice.querystring());
   }
+  slice.container.html('');
   slice.render(force);
 }
 

diff --git a/superset/assets/javascripts/modules/superset.js b/superset/assets/javascripts/modules/superset.js
@@ -177,6 +177,9 @@ const px = function () {
         always(data);
         controller.error(this);
       },
+      clearError() {
+        $(selector + ' div.alert').remove();
+      },
       width() {
         return token.width();
       },

diff --git a/superset/assets/visualizations/nvd3_vis.js b/superset/assets/visualizations/nvd3_vis.js
@@ -60,13 +60,14 @@ function nvd3Vis(slice) {
 
   const render = function () {
     d3.json(slice.jsonEndpoint(), function (error, payload) {
-      slice.container.html('');
       // Check error first, otherwise payload can be null
       if (error) {
         slice.error(error.responseText, error);
         return;
       }
 
+      slice.clearError();
+
       // Calculates the longest label size for stretching bottom margin
       function calculateStretchMargins(payloadData) {
         let stretchMargin = 0;