Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard debug string representation of data objects. #95

Closed
wants to merge 2 commits into from

Conversation

matux
Copy link
Collaborator

@matux matux commented Mar 10, 2023

Description of the change

Standardizes the debug string representation of data objects so they don't appear as "Instance of [SomeClass]" in the debugger and when printing.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • This was a simple chore that wasn't tracked.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux requested a review from diegov March 10, 2023 16:48
@matux matux self-assigned this Mar 10, 2023
@matux
Copy link
Collaborator Author

matux commented Mar 10, 2023

Mirroring isn't supported natively on some platforms and I'm tired of dealing with this horrible language and VM, so I'll take it over some other day that I have free time.

@matux matux closed this Mar 10, 2023
mixin DebugStringRepresentation {
@override
String toString() {
final instanceMirror = reflect(this);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed via chat, it looks like this won't work in AOT mode. Shame!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants