Skip to content

Commit

Permalink
base-files: fix message of initscript wrapper
Browse files Browse the repository at this point in the history
currently (after blogic's edit to my commit) it prints like this:

root@lede:/# service aa
aa does not exist. the following services are available :adblock       dnsmasq       gpio_switch   rpcd          system
boot          done          led           sqm           uhttpd
crelay        dropbear      log           sysctl        umount
cron          firewall      network       sysfixtime    urandom_seed
ddns          fstab         odhcpd        sysntpd

which looks pretty bad, and is even worse if someone writes only "service" without arguments, as it will print " does not exist. " which is confusing.

with this commit it looks like this:

root@lede:/# service
service "" not found, the following services are available:
adblock       dnsmasq       gpio_switch   rpcd          system
boot          done          led           sqm           uhttpd
crelay        dropbear      log           sysctl        umount
cron          firewall      network       sysfixtime    urandom_seed
ddns          fstab         odhcpd        sysntpd

Yes there is some play with " and ', it is to display "name" or just "" if no service name is entered (like in the example).

Signed-off-by: Alberto Bursi <[email protected]>
  • Loading branch information
bobafetthotmail authored and jow- committed Jan 2, 2017
1 parent 5639e45 commit 8496659
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package/base-files/files/etc/profile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ fi

service() {
[ -f "/etc/init.d/$1" ] || {
echo -n "$1 does not exist. the following services are available :"
echo "service "'"'"$1"'"'" not found, the following services are available:"
ls "/etc/init.d"
return 1
}
Expand Down

0 comments on commit 8496659

Please sign in to comment.