-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_*() consistency #242
get_*() consistency #242
Conversation
…bit. Now works with the matcher utility and outputs a tibble.
…ymore. Now a synonym foer 8669
Merge branch 'master' into git-consistency # Conflicts: # NAMESPACE # tests/testthat/test-chemspider.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Aariq! I am very happy that this PR implements the conclusions of our earlier discussion, the tibble
upgrade and matcher()
are great! One thing I noticed, we seem to be increasing the number of dependencies (I also added data.tree
in another PR), maybe this is something we should discuss in more detail in another issue.
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 19 19
Lines 1750 1750
======================================
Misses 1750 1750 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is ready to be merged. Thanks @Aariq!!
Pull Request
This addresses #193 and implements a consistent API and output (tibble) format for all
get_*()
functions.It also adds a new (non-exported) utility function,
matcher
that maybe should superseedchooser
eventually. This should be able to handle thematch
argument of most functions.PR task list:
devtools::document()