Skip to content

Commit

Permalink
Remove legacy rosbuild files (#231)
Browse files Browse the repository at this point in the history
This package is distributed as a standalone Python package in all
versions of ROS, and has been for many releases. This manifest and
CMakeLists.txt are from the transitional days around when catkin first
emerged, when it appears that rospkg was distributed as a ROS package
instead of a standalone python package.

The presence of a 'dry' manifest is confusing colcon and serves no
useful purpose anymore.
  • Loading branch information
cottsay authored Oct 29, 2021
1 parent c4d79d6 commit 8d4f4c1
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 32 deletions.
11 changes: 0 additions & 11 deletions CMakeLists.txt

This file was deleted.

19 changes: 0 additions & 19 deletions manifest.xml

This file was deleted.

Empty file.
6 changes: 4 additions & 2 deletions test/test_rospkg_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,13 +314,15 @@ def test_get_package_name():
from rospkg import __version__
from rospkg import get_package_name

# test dir is a subdirectory of this package
test_dir = get_package_test_path()
assert get_package_name(test_dir) in ['rospkg', 'rospkg-%s' % __version__], get_package_name(test_dir)

test_dir_foo = os.path.join(test_dir, 'p1', 'foo')
assert 'foo' == get_package_name(test_dir_foo)

# baz dir is a subdirectory of foo package
test_dir_foo_baz = os.path.join(test_dir_foo, 'baz')
assert 'foo' == get_package_name(test_dir_foo_baz)

# test with path outside of our hierarchy
assert get_package_name(tempfile.tempdir) is None

Expand Down

0 comments on commit 8d4f4c1

Please sign in to comment.