Skip to content

Commit

Permalink
Use FdoDetect to identify Raspbian systems (#257)
Browse files Browse the repository at this point in the history
Raspbian Buster was close enough to vanilla Debian Buster that the
implementation of the Debian detector in os_detect identified it as
such. Things changed in Raspbian Bullsye, and it became necessary to
start identifying Raspbian as a discrete platform. This commit makes
that change.

For Raspbian Bullseye, this is not a breaking change because the
previous behavior was to fail to detect. On Raspbian Buster, this change
will break rosdep versions prior to 0.22.0, where the alias was added.

Another note is that the FdoDetect implementation doesn't output the
minor version number, but I'm not aware of any downstream code using the
version number of Debian platforms at all.
  • Loading branch information
cottsay authored Mar 6, 2023
1 parent 83c263c commit cd04dde
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/rospkg/os_detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,7 @@ def get_codename(self):
OsDetect.register_default(OS_OSX, OSX())
OsDetect.register_default(OS_POP, LsbDetect("Pop"))
OsDetect.register_default(OS_QNX, QNX())
OsDetect.register_default(OS_RASPBIAN, FdoDetect("raspbian"))
OsDetect.register_default(OS_RHEL, FdoDetect("rhel"))
OsDetect.register_default(OS_ROCKY, FdoDetect("rocky"))
OsDetect.register_default(OS_SLACKWARE, Slackware())
Expand Down

0 comments on commit cd04dde

Please sign in to comment.