Fix warning about using features in patch for smartcore (risc0#1017)

Modify the smartcore-ml example to use smartcore as a direct dependency, silencing a warning and avoiding unnecessary use of the patch mechanism.
rose578 · Oct 24, 2023 · c272d48 · c272d48
1 parent 15d7ac4
commit c272d48
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 12 deletions.
diff --git a/examples/Cargo.lock b/examples/Cargo.lock
diff --git a/examples/Cargo.toml b/examples/Cargo.toml
@@ -43,6 +43,3 @@ lto = true
 
 [profile.release.build-override]
 opt-level = 3
-
-[patch.crates-io]
-smartcore = { git = "https://github.com/risc0/smartcore.git", features = ["serde"] }
diff --git a/examples/smartcore-ml/Cargo.toml b/examples/smartcore-ml/Cargo.toml
@@ -7,7 +7,8 @@ edition = "2021"
 risc0-zkvm = { path = "../../risc0/zkvm" }
 rmp-serde = "1.1"
 serde_json = "1.0"
-smartcore = { version = "0.3", features = ["serde"] }
+# Using git dependency as a workaround for https://github.com/smartcorelib/smartcore/issues/267
+smartcore = { git = "https://github.com/risc0/smartcore.git", rev = "4bd3cadd50ed988c45c239f5264c3e2c2af0a690", features = ["serde"] }
 smartcore-ml-methods = { path = "methods" }
 
 [features]

diff --git a/examples/smartcore-ml/methods/guest/Cargo.lock b/examples/smartcore-ml/methods/guest/Cargo.lock
diff --git a/examples/smartcore-ml/methods/guest/Cargo.toml b/examples/smartcore-ml/methods/guest/Cargo.toml
@@ -9,7 +9,5 @@ edition = "2021"
 risc0-zkvm = { path = "../../../../risc0/zkvm", default-features = false, features = [
   "std",
 ] }
-smartcore = { version = "0.3", features = ["serde"]}
-
-[patch.crates-io]
-smartcore = { git = "https://github.com/risc0/smartcore.git", features = ['serde'] }
+# Using git dependency as a workaround for https://github.com/smartcorelib/smartcore/issues/267
+smartcore = { git = "https://github.com/risc0/smartcore.git", rev = "4bd3cadd50ed988c45c239f5264c3e2c2af0a690", features = ["serde"]}