Skip to content

Commit

Permalink
fbdev: stifb: Fall back to cfb_fillrect() on 32-bit HCRX cards
Browse files Browse the repository at this point in the history
When the text console is scrolling text upwards it calls the fillrect()
function to empty the new line. The current implementation doesn't seem
to work correctly on HCRX cards in 32-bit mode and leave garbage in that
line instead. Fix it by falling back to standard cfb_fillrect() in that
case.

Signed-off-by: Helge Deller <[email protected]>
Cc: <[email protected]>
  • Loading branch information
hdeller committed Oct 18, 2022
1 parent 3c6174f commit 776d875
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/video/fbdev/stifb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1055,7 +1055,8 @@ stifb_fillrect(struct fb_info *info, const struct fb_fillrect *rect)
{
struct stifb_info *fb = container_of(info, struct stifb_info, info);

if (rect->rop != ROP_COPY)
if (rect->rop != ROP_COPY ||
(fb->id == S9000_ID_HCRX && fb->info.var.bits_per_pixel == 32))
return cfb_fillrect(info, rect);

SETUP_HW(fb);
Expand Down

0 comments on commit 776d875

Please sign in to comment.