Skip to content

Commit

Permalink
core.quotePath=false so that get-diff-action can cope with non-ascii …
Browse files Browse the repository at this point in the history
…file paths (mdn#3381)

* test if ascii affects the get-diff-action

* undo

* testing

* testing

* comment

* undo the experiment itself
  • Loading branch information
peterbe authored Mar 26, 2021
1 parent 1d2c354 commit f6fc57f
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions .github/workflows/pr-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,27 @@ jobs:
run: |
yarn --frozen-lockfile
- name: Config git core.quotePath
run: |
# If you don't do this, the get-diff-action won't be able to
# notice files that contain non-ascii characters.
# I.e.
#
# ▶ git status
# Changes not staged for commit:
# ...
# modified: "files/en-us/glossary/b\303\251zier_curve/index.html"
#
# But after you set `core.quotePath` you get:
#
# ▶ git status
# Changes not staged for commit:
# ...
# modified: "files/en-us/glossary/bézier_curve/index.html"
#
# Now, this gets used by the `git diff ...` inside get-diff-action.
git config --global core.quotePath false
- uses: technote-space/[email protected]
id: git_diff_content
with:
Expand Down

0 comments on commit f6fc57f

Please sign in to comment.