Replace findbugs with spotbugsDebug in Circle CI's config, Contributi…

…on guide and Pull request template

.circleci/config.yml

@@ -120,7 +120,7 @@ jobs:
 #           This implies building the release and test flavors as well, which are out of scope for this job.
 #           Instead, using lintDebug it's running only once, for the 'debug' flavor that we are building here
 #           This means ~3x faster for the lint task.
-            command: ./gradlew pmd checkstyle lintDebug findbugs
+            command: ./gradlew pmd checkstyle lintDebug spotbugsDebug
         - store_artifacts:
             path: collect_app/build/reports
             destination: reports

.github/PULL_REQUEST_TEMPLATE.md

@@ -18,5 +18,5 @@ https://github.com/opendatakit/collect/blob/master/CONTRIBUTING.md
 #### Does this change require updates to documentation? If so, please file an issue [here]( https://github.com/opendatakit/docs/issues/new) and include the link below.
 
 #### Before submitting this PR, please make sure you have:
-- [ ] run `./gradlew pmd checkstyle lint findbugs` and confirmed all checks still pass.
+- [ ] run `./gradlew pmd checkstyle lintDebug spotbugsDebug` and confirmed all checks still pass.
 - [ ] verified that any new UI elements use theme colors. [UI Components Style guidelines](https://github.com/opendatakit/collect/blob/master/CONTRIBUTING.md#ui-components-style-guidelines)

CONTRIBUTING.md

@@ -23,7 +23,7 @@ To contribute code to ODK Collect, you will need to open a [pull request](https:
 
         git push
         
-1. Once you have completed your code changes, verify that you have followed the [style guidelines](https://github.com/opendatakit/collect/blob/master/CONTRIBUTING.md#style-guidelines). Additionally, [lint](https://developer.android.com/studio/write/lint.html) is run for each new build so please run `gradle lint` and fix any errors before issuing a pull request.
+1. Once you have completed your code changes, verify that you have followed the [style guidelines](https://github.com/opendatakit/collect/blob/master/CONTRIBUTING.md#style-guidelines).
 
 1. When your changes are ready to be added to the core ODK Collect project, [open a pull request](https://help.github.com/articles/creating-a-pull-request/). Make sure to set the base fork to `opendatakit/collect`. Describe your changes in the comment, refer to any relevant issues using [keywords for closing issues](https://help.github.com/articles/closing-issues-via-commit-messages/) and tag any person you think might need to know about the changes.
 
@@ -38,7 +38,7 @@ To contribute code to ODK Collect, you will need to open a [pull request](https:
 
 1. Keep your pull request focused on one narrow goal. This could mean addressing an issue with multiple, smaller pull requests. Small pull requests are easier to review and less likely to introduce bugs. If you would like to make stylistic changes to the code, create a separate pull request.
 
-1. Run `./gradlew lint checkstyle pmd findbugs` and fix any errors.
+1. Run `./gradlew pmd checkstyle lintDebug spotbugsDebug` and fix any errors.
 
 1. Write clear code. Use descriptive names and create meaningful abstractions (methods, classes).