gossipd: don't publish private updates after channel_announce.

We generate new ones anyway; removing this code changes fixes coming up which now only need to change one place. Signed-off-by: Rusty Russell <[email protected]>
rrybarczyk · Jun 6, 2018 · 2431742 · 2431742
1 parent 27a186b
commit 2431742
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/gossipd/routing.c b/gossipd/routing.c
@@ -638,13 +638,10 @@ bool routing_add_channel_announcement(struct routing_state *rstate,
 	/* Now we can broadcast channel announce */
 	insert_broadcast(rstate->broadcasts, chan->channel_announce);
 
-	/* If we had private updates for channels, we can broadcast them too. */
-	for (size_t i = 0; i < ARRAY_SIZE(chan->half); i++) {
-		if (!is_halfchan_defined(&chan->half[i]))
-			continue;
-		insert_broadcast(rstate->broadcasts,
-				 chan->half[i].channel_update);
-	}
+	/* Clear any private updates. */
+	for (size_t i = 0; i < ARRAY_SIZE(chan->half); i++)
+		chan->half[i].channel_update
+			= tal_free(chan->half[i].channel_update);
 
 	return true;
 }