Skip to content

Commit

Permalink
Rename registrydisk -> containerdisk in doc
Browse files Browse the repository at this point in the history
  • Loading branch information
petrkotas committed Nov 28, 2018
1 parent 3e063b9 commit 45a2634
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions docs/cloud-init.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
domain:
devices:
disks:
- type: RegistryDisk:v1alpha
- type: ContainerDisk:v1alpha
source:
name: kubevirt/cirros-registry-disk-demo:devel
target:
Expand Down Expand Up @@ -100,7 +100,7 @@ spec:
domain:
devices:
disks:
- type: RegistryDisk:v1alpha
- type: ContainerDisk:v1alpha
source:
name: kubevirt/cirros-registry-disk-demo:devel
target:
Expand Down
6 changes: 3 additions & 3 deletions docs/container-empty-disks.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,16 @@ spec:
devices:
disks:
- name: disk1
volumeName: registryDisk
volumeName: containerDisk
disk:
dev: vda
- name: disk2
volumeName: emptyDisk
disk:
dev: vdb
volumes:
- name: registryDisk
registryDisk:
- name: containerDisk
containerDisk:
image: kubevirt/cirros-registry-disk-demo:devel
- name: emptyDisk
emptyDisk:
Expand Down
8 changes: 4 additions & 4 deletions docs/container-register-disks.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ spec:
domain:
devices:
disks:
- type: RegistryDisk:v1alpha
- type: ContainerDisk:v1alpha
- source:
name: vmdisks/fedora25:latest
- target:
Expand All @@ -89,18 +89,18 @@ spec:
**KubeVirt Runtime Implementation**

When virt-controller sees a VMI object with a disk type of
**RegistryDisk:v1alpha**, virt-controller places the image wrapper container
**ContainerDisk:v1alpha**, virt-controller places the image wrapper container
in the virt-launcher pod along with the container that monitors the VMI process.

When the virt-launcher pod starts, the wrapper container copies the user's VMI
image as file on a shared host directory.

When virt-handler sees a VMI is placed on the local node with the
**RegistryDisk:v1alpha** disk type defined, virt-handler injects the
**ContainerDisk:v1alpha** disk type defined, virt-handler injects the
necessary configuration into the domain xml required to add the disk backed by
a local file.

The **v1** part of the RegistryDisk disk type represents the standard
The **v1** part of the ContainerDisk disk type represents the standard
used during the virt-handler disk conversion process. As we gain more
experience with this feature, we may want to adopt a new standard for how VMI
images are wrapped by a container while maintaining backwards compatibility.
2 changes: 1 addition & 1 deletion docs/vm-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ spec:
volumeName: volume3
volumes:
- name: volume0
registryDisk:
containerDisk:
image: test/image
- name: volume1
cloudInitNoCloud:
Expand Down

0 comments on commit 45a2634

Please sign in to comment.