Skip to content

Commit

Permalink
Fix inconsistency in datavolume functional test
Browse files Browse the repository at this point in the history
Signed-off-by: David Vossel <[email protected]>
  • Loading branch information
davidvossel committed Feb 7, 2019
1 parent fc68e41 commit 5e92ddb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/virt-controller/watch/vm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ var _ = Describe("VirtualMachine", func() {
testutils.ExpectEvent(recorder, SuccessfulDataVolumeCreateReason)
})

It("should not failed DataVolume for VirtualMachineInstance until after timeout", func() {
It("should not delete failed DataVolume for VirtualMachineInstance until after timeout", func() {
vm, _ := DefaultVirtualMachine(true)
vm.Spec.Template.Spec.Volumes = append(vm.Spec.Template.Spec.Volumes, v1.Volume{
Name: "test1",
Expand Down
2 changes: 1 addition & 1 deletion tests/datavolume_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ var _ = Describe("DataVolume Integration", func() {

By("Waiting for VMI to be created")
Eventually(func() v1.VirtualMachineInstancePhase {
vmi, err = virtClient.VirtualMachineInstance(vmi.Namespace).Get(vm.GetName(), &metav1.GetOptions{})
vmi, err = virtClient.VirtualMachineInstance(vm.Namespace).Get(vm.GetName(), &metav1.GetOptions{})
if err != nil {
Expect(err.Error()).To(ContainSubstring("not found"),
"A 404 while VMI is being created would be normal. All other errors are unexpected")
Expand Down

0 comments on commit 5e92ddb

Please sign in to comment.