forked from akvelon/beam
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request apache#17341 [BEAM-1754] Adds experimental Typescr…
…ipt Beam SDK
- Loading branch information
Showing
98 changed files
with
41,332 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
# To learn more about GitHub Actions in Apache Beam check the CI.md | ||
|
||
name: TypeScript Tests | ||
|
||
on: | ||
workflow_dispatch: | ||
schedule: | ||
- cron: '10 2 * * *' | ||
push: | ||
branches: ['master', 'release-*', 'javascript'] | ||
tags: 'v*' | ||
pull_request: | ||
branches: ['master', 'release-*', 'javascript'] | ||
tags: 'v*' | ||
paths: ['sdks/typescript/**'] | ||
|
||
|
||
jobs: | ||
|
||
typescript_unit_tests: | ||
name: 'TypeScript Unit Tests' | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-latest, macos-latest, windows-latest] | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v2 | ||
with: | ||
persist-credentials: false | ||
submodules: recursive | ||
- name: Install node | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: '16' | ||
- run: npm install | ||
working-directory: ./sdks/typescript | ||
- run: npm run build | ||
working-directory: ./sdks/typescript | ||
- run: npm run prettier-check | ||
working-directory: ./sdks/typescript | ||
if: ${{ matrix.os == 'ubuntu-latest' }} | ||
# - run: npm run codecovTest | ||
# working-directory: ./sdks/typescript | ||
# if: ${{ matrix.os == 'ubuntu-latest' }} | ||
- run: npm test | ||
working-directory: ./sdks/typescript | ||
# if: ${{ matrix.os != 'ubuntu-latest' }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
lib-cov | ||
*.seed | ||
*.log | ||
*.csv | ||
*.dat | ||
*.out | ||
*.pid | ||
*.gz | ||
*.swp | ||
|
||
pids | ||
logs | ||
results | ||
tmp | ||
|
||
# Build | ||
public/css/main.css | ||
|
||
# Coverage reports | ||
coverage | ||
|
||
# API keys and secrets | ||
.env | ||
|
||
# Dependency directory | ||
node_modules | ||
bower_components | ||
|
||
# Editors | ||
.idea | ||
*.iml | ||
|
||
# OS metadata | ||
.DS_Store | ||
Thumbs.db | ||
|
||
# Ignore built js files | ||
dist/**/* | ||
|
||
# ignore yarn.lock | ||
yarn.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# | ||
# Licensed to the Apache Software Foundation (ASF) under one or more | ||
# contributor license agreements. See the NOTICE file distributed with | ||
# this work for additional information regarding copyright ownership. | ||
# The ASF licenses this file to You under the Apache License, Version 2.0 | ||
# (the "License"); you may not use this file except in compliance with | ||
# the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
package*.json | ||
dist/ | ||
src/apache_beam/proto | ||
README.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
############################################################################### | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
############################################################################### | ||
|
||
FROM node:16 | ||
MAINTAINER "Apache Beam <[email protected]>" | ||
|
||
ENV NODE_ENV=development | ||
|
||
WORKDIR /app | ||
|
||
# Copy configs for dependencies and TypeScript complilation settings. | ||
COPY ["package.json", "package-lock.json*", "tsconfig.json", "./"] | ||
|
||
# Copy source code | ||
COPY src ./src | ||
|
||
# Install dependencies and compile | ||
RUN npm install | ||
RUN npm run build | ||
|
||
# Check that filesystem is set up as expected | ||
RUN ls -a | ||
|
||
COPY boot /opt/apache/beam/ | ||
ENTRYPOINT ["/opt/apache/beam/boot"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,184 @@ | ||
<!-- | ||
Licensed to the Apache Software Foundation (ASF) under one | ||
or more contributor license agreements. See the NOTICE file | ||
distributed with this work for additional information | ||
regarding copyright ownership. The ASF licenses this file | ||
to you under the Apache License, Version 2.0 (the | ||
"License"); you may not use this file except in compliance | ||
with the License. You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, | ||
software distributed under the License is distributed on an | ||
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
KIND, either express or implied. See the License for the | ||
specific language governing permissions and limitations | ||
under the License. | ||
--> | ||
|
||
# Typescript Beam SDK | ||
|
||
This is the start of a fully functioning Javascript (actually, Typescript) SDK. | ||
There are two distinct aims with this SDK | ||
|
||
1. Tap into the large (and relatively underserved, by existing data processing | ||
frameworks) community of javascript developers with a native SDK targeting this language. | ||
|
||
1. Develop a new SDK which can serve both as a proof of concept and reference | ||
that highlights the (relative) ease of porting Beam to new languages, | ||
a differentiating feature of Beam and Dataflow. | ||
|
||
To accomplish this, we lean heavily on the portability framework. | ||
For example, we make heavy use of cross-language transforms, | ||
in particular for IOs. | ||
In addition, the direct runner is simply an extension of the worker suitable | ||
for running on portable runners such as the ULR, which will directly transfer | ||
to running on production runners such as Dataflow and Flink. | ||
The target audience should hopefully not be put off by running other-language | ||
code encapsulated in docker images. | ||
|
||
## API | ||
|
||
We generally try to apply the concepts from the Beam API in a Typescript | ||
idiomatic way, but it should be noted that few of the initial developers | ||
have extensive (if any) Javascript/Typescript development experience, so | ||
feedback is greatly appreciated. | ||
|
||
In addition, some notable departures are taken from the traditional SDKs: | ||
|
||
* We take a "relational foundations" approach, where | ||
[schema'd data](https://docs.google.com/document/d/1tnG2DPHZYbsomvihIpXruUmQ12pHGK0QIvXS1FOTgRc/edit#heading=h.puuotbien1gf) | ||
is the primary way to interact with data, and we generally eschew the key-value | ||
requiring transforms in favor of a more flexible approach naming fields or | ||
expressions. Javascript's native Object is used as the row type. | ||
|
||
* As part of being schema-first we also de-emphasize Coders as a first-class | ||
concept in the SDK, relegating it to an advance feature used for interop. | ||
Though we can infer schemas from individual elements, it is still TBD to | ||
figure out if/how we can leverage the type system and/or function introspection | ||
to regularly infer schemas at construction time. A fallback coder using BSON | ||
encoding is used when we don't have sufficient type information. | ||
|
||
* We have added additional methods to the PCollection object, notably `map` | ||
and `flatmap`, [rather than only allowing apply](https://www.mail-archive.com/[email protected]/msg06035.html). | ||
In addition, `apply` can accept a function argument `(PColletion) => ...` as | ||
well as a PTransform subclass, which treats this callable as if it were a | ||
PTransform's expand. | ||
|
||
* In the other direction, we have eliminated the | ||
[problematic Pipeline object](https://s.apache.org/no-beam-pipeline) | ||
from the API, instead providing a `Root` PValue on which pipelines are built, | ||
and invoking run() on a Runner. We offer a less error-prone `Runner.run` | ||
which finishes only when the pipeline is completely finished as well as | ||
`Runner.runAsync` which returns a handle to the running pipeline. | ||
|
||
* Rather than introduce PCollectionTuple, PCollectionList, etc. we let PValue | ||
literally be an | ||
[array or object with PValue values](https://github.com/robertwb/beam-javascript/blob/de4390dd767f046903ac23fead5db333290462db/sdks/node-ts/src/apache_beam/pvalue.ts#L116) | ||
which transforms can consume or produce. | ||
These are applied by wrapping them with the `P` operator, e.g. | ||
`P([pc1, pc2, pc3]).apply(new Flatten())`. | ||
|
||
* Like Python, `flatMap` and `ParDo.process` return multiple elements by | ||
yielding them from a generator, rather than invoking a passed-in callback. | ||
TBD how to output to multiple distinct PCollections. | ||
There is currently an operation to split a PCollection into multiple | ||
PCollections based on the properties of the elements, and | ||
we may consider using a callback for side outputs. | ||
|
||
* The `map`, `flatMap`, and `ParDo.proceess` methods take an additional | ||
(optional) context argument, which is similar to the keyword arguments | ||
used in Python. These can be "ordinary" javascript objects (which are passed | ||
as is) or special DoFnParam objects which provide getters to element-specific | ||
information (such as the current timestamp, window, or side input) at runtime. | ||
|
||
* Javascript supports (and encourages) an asynchronous programing model, with | ||
many libraries requiring use of the async/await paradigm. | ||
As there is no way (by design) to go from the asyncronous style back to | ||
the synchronous style, this needs to be taken into account | ||
when designing the API. | ||
We currently offer asynchronous variants of `PValue.apply(...)` (in addition | ||
to the synchronous ones, as they are easier to chain) as well as making | ||
`Runner.run` asynchronous. TBD to do this for all user callbacks as well. | ||
|
||
An example pipeline can be found at https://github.com/robertwb/beam-javascript/blob/javascript/sdks/node-ts/src/apache_beam/examples/wordcount.ts | ||
|
||
## TODO | ||
|
||
This SDK is a work in progress. In January 2022 we developed the ability to | ||
construct and run basic pipelines (including external transforms and running | ||
on a portable runner) but the following big-ticket items remain. | ||
|
||
* Containerization | ||
|
||
* Actually use worker threads for multiple bundles. | ||
|
||
* Build and test containers with gradle tasks. | ||
|
||
* API | ||
|
||
* There are several TODOs of minor features or design decisions to finalize. | ||
|
||
* Consider using (or supporting) 2-arrays rather than {key, value} objects | ||
for KVs. | ||
|
||
* Force the second argument of map/flatMap to be an Object, which would lead | ||
to a less confusing API (vs. Array.map) and clean up the implementation. | ||
Also add a [do]Filter, and possibly a [do]Reduce? | ||
|
||
* Move away from using classes. | ||
|
||
* Advanced features like metrics, state, timers, and SDF. | ||
Possibly some of these can wait. | ||
|
||
* Other | ||
|
||
* Enforce unique names for pipeline update. | ||
|
||
* Cleanup uses of var, this. Arrow functions. `===` vs `==`. | ||
|
||
* Avoid `any` return types (and re-enable check in compiler). | ||
|
||
* Relative vs. absoute imports, possibly via setting a base url with a | ||
`jsconfig.json`. | ||
|
||
* More/better tests, including tests of illegal/unsupported use. | ||
|
||
* Set channel options like `grpc.max_{send,receive}_message_length` as we | ||
do in other SDKs. | ||
|
||
* Reduce use of any. | ||
|
||
* Could use `unknown` in its place where the type is truly unknown. | ||
|
||
* It'd be nice to enforce, maybe re-enable `noImplicitAny: true` in | ||
tsconfig if we can get the generated proto files to be ignored. | ||
|
||
* Enable a linter like eslint and fix at least the low hanging fruit. | ||
|
||
There is probably more; there are many TODOs littered throughout the code. | ||
|
||
## Development. | ||
|
||
### Getting stared | ||
|
||
Install node.js, and then from within `sdks/typescript`. | ||
|
||
``` | ||
npm install | ||
``` | ||
|
||
### Running tests | ||
|
||
``` | ||
$ npm test | ||
``` | ||
|
||
### Style | ||
|
||
We have adopted prettier which can be run with | ||
|
||
``` | ||
# npx prettier --write . | ||
``` |
Oops, something went wrong.