Merge pull request sonata-project#2660 from pulzarraider/translator_c…

…heck Added check if translator service is enabled.
rswork · Jan 5, 2015 · b6999b1 · b6999b1
2 parents 524d1b1 + 532ce3a
commit b6999b1
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 0 deletions.
diff --git a/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php b/DependencyInjection/Compiler/AddDependencyCallsCompilerPass.php
@@ -31,6 +31,16 @@ class AddDependencyCallsCompilerPass implements CompilerPassInterface
      */
     public function process(ContainerBuilder $container)
     {
+        // check if translator service exist
+        if (!$container->hasAlias('translator')) {
+            throw new \RuntimeException('The "translator" service is not yet enabled.
+                It\'s required by SonataAdmin to display all labels properly.
+
+                To learn how to enable the translator service please visit:
+                http://symfony.com/doc/current/book/translation.html#book-translation-configuration
+             ');
+        }
+
         $parameterBag = $container->getParameterBag();
         $groupDefaults = $admins = $classes = array();
 

diff --git a/Tests/DependencyInjection/Compiler/AddDependencyCallsCompilerPassTest.php b/Tests/DependencyInjection/Compiler/AddDependencyCallsCompilerPassTest.php
@@ -34,6 +34,26 @@ public function setUp()
         $this->config    = $this->getConfig();
     }
 
+    public function testTranslatorDisabled()
+    {
+        $this->setExpectedException(
+          'RuntimeException', 'The "translator" service is not yet enabled.
+                It\'s required by SonataAdmin to display all labels properly.
+
+                To learn how to enable the translator service please visit:
+                http://symfony.com/doc/current/book/translation.html#book-translation-configuration
+             '
+        );
+
+        $container = $this->getContainer();
+        $container->removeAlias('translator');
+        $this->extension->load(array($this->config), $container);
+
+        $compilerPass = new AddDependencyCallsCompilerPass();
+        $compilerPass->process($container);
+        $container->compile();
+    }
+
     /**
      * @covers Sonata\AdminBundle\DependencyInjection\Compiler\AddDependencyCallsCompilerPass::process
      */
@@ -314,6 +334,12 @@ private function getContainer()
             ->setArguments(array('', 'Sonata\AdminBundle\Tests\DependencyInjection\Article', 'SonataAdminBundle:CRUD'))
             ->addTag('sonata.admin', array('group' => 'sonata_group_one', 'manager_type' => 'doctrine_phpcr'));
 
+        // translator
+        $container
+            ->register('translator.default')
+            ->setClass('Symfony\Bundle\FrameworkBundle\Translation\Translator');
+        $container->setAlias('translator', 'translator.default');
+
         return $container;
     }
 }
diff --git a/composer.json b/composer.json
@@ -27,6 +27,7 @@
         "symfony/twig-bridge": "~2.3",
         "symfony/class-loader":"~2.3",
         "sensio/generator-bundle": "~2.3",
+        "symfony/translation":"~2.3",
         "twig/twig": "~1.15",
         "twig/extensions": "~1.0",
         "sonata-project/exporter": "~1.0",