Fix panic on bad tx signature (privacy-scaling-explorations#889)

rtang03 · Nov 11, 2022 · 1c3c9a4 · 1c3c9a4
1 parent 32166f6
commit 1c3c9a4
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/eth-types/src/geth_types.rs b/eth-types/src/geth_types.rs
@@ -206,7 +206,10 @@ impl Transaction {
             .to_vec()
             .try_into()
             .expect("hash length isn't 32 bytes");
-        let v = (self.v - 35 - chain_id * 2) as u8;
+        let v = self
+            .v
+            .checked_sub(35 + chain_id * 2)
+            .ok_or(Error::Signature(libsecp256k1::Error::InvalidSignature))? as u8;
         let pk = recover_pk(v, &self.r, &self.s, &msg_hash)?;
         // msg_hash = msg_hash % q
         let msg_hash = BigUint::from_bytes_be(msg_hash.as_slice());