remove enhanced_grade_change_query feature flag

note that the ENV variable is still necessary because the feature depends on auditor configuration which may be different in OSS installations once we remove Cassandra auditors, the ENV var can go away test plan: - grade change audit searches in account admin tools should function on multiple criteria closes LS-1983 Change-Id: Idae2973aaa5a4ee712d75f337b5fd59c06c6ce96 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261865 Tested-by: Service Cloud Jenkins <[email protected]> Reviewed-by: Nate Armstrong <[email protected]> QA-Review: Nate Armstrong <[email protected]> Product-Review: Jeremy Stanley <[email protected]>
rthbound · Mar 30, 2021 · 64ea9b4 · 64ea9b4
1 parent c11355d
commit 64ea9b4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/app/controllers/accounts_controller.rb b/app/controllers/accounts_controller.rb
@@ -1148,8 +1148,7 @@ def admin_tools
                       Account.site_admin.grants_right?(@current_user, :read_messages),
        logging: logging
       }
-    js_env enhanced_grade_change_query: Auditors::read_from_postgres? &&
-      Account.site_admin.feature_enabled?(:enhanced_grade_change_query)
+    js_env enhanced_grade_change_query: Auditors::read_from_postgres?
     js_env bounced_emails_admin_tool: @account.grants_right?(@current_user, session, :view_bounced_emails)
   end
 

diff --git a/config/feature_flags/learning_activities_release_flags.yml b/config/feature_flags/learning_activities_release_flags.yml
@@ -48,11 +48,6 @@ autocreate_attachment_from_media_object:
     Creates file objects (initially hidden to students if in a Course) after
     media is uploaded or recorded through the RCE.
   applies_to: RootAccount
-enhanced_grade_change_query:
-  state: hidden
-  display_name: Enhanced grade change auditing
-  description: Allow searching grade change audit logs by multiple criteria
-  applies_to: SiteAdmin
 new_file_url_rewriting:
   state: hidden
   display_name: Update file links to prefer preview, not download