Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Axlsx #392

Closed
wants to merge 1 commit into from
Closed

Conversation

jkowens
Copy link

@jkowens jkowens commented Feb 8, 2023

Add support for rendering Open Office Spreadsheets using Caxlsx. "Templating" would be the same as used by caxlsx_rails.

@jeremyevans
Copy link
Contributor

Can this support be shipped with caxlsx, or in an external tilt-caxlsx gem? I'm not sure we (tilt maintainers) want the additional dependencies to test, consideration potential usage seems minimal. @judofyr what do you think?

@jkowens
Copy link
Author

jkowens commented Feb 8, 2023

@jeremyevans yeah it could be it's own gem for sure. When I saw this in the readme I figured I'd send up a PR:

The Tilt team will liberally accept pull requests against the template integration. It's up to the community as a whole to make sure the integration stays consistent and backwards compatible over time.

I definitely understand the concern about adding more dependencies and support effort for maintainers 😅

@jeremyevans
Copy link
Contributor

@jeremyevans yeah it could be it's own gem for sure. When I saw this in the readme I figured I'd send up a PR:

The Tilt team will liberally accept pull requests against the template integration. It's up to the community as a whole to make sure the integration stays consistent and backwards compatible over time.

That's a good point. We should probably remove that language, considering we ended up in a situation where we have many rarely used template engines that we have to support.

@jkowens
Copy link
Author

jkowens commented Feb 8, 2023

@jeremyevans I'm going to go ahead and close. I appreciate the quick feedback.

@jkowens jkowens closed this Feb 8, 2023
@jeremyevans
Copy link
Contributor

OK. If you want to ship tilt caxlsx support in an external gem, we can mention it in the README to increase awareness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants