Skip to content

Commit

Permalink
hwmon: (w83795) Use dev_get_drvdata() where possible
Browse files Browse the repository at this point in the history 
When we don't need the client pointer, calling dev_get_drvdata() is
more efficient that calling to_i2c_client() and then
i2c_get_clientdata().

Signed-off-by: Jean Delvare <[email protected]>
  • Loading branch information
Jean Delvare authored and Jean Delvare committed Oct 28, 2010
1 parent 1bb3450 commit 21fc977
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/hwmon/w83795.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1265,8 +1265,7 @@ store_temp(struct device *dev, struct device_attribute *attr,
static ssize_t
show_dts_mode(struct device *dev, struct device_attribute *attr, char *buf)
{
struct i2c_client *client = to_i2c_client(dev);
struct w83795_data *data = i2c_get_clientdata(client);
struct w83795_data *data = dev_get_drvdata(dev);
int tmp;

if (data->enable_dts & 2)
Expand Down Expand Up @@ -1296,8 +1295,7 @@ show_dts_ext(struct device *dev, struct device_attribute *attr, char *buf)
struct sensor_device_attribute_2 *sensor_attr =
to_sensor_dev_attr_2(attr);
int nr = sensor_attr->nr;
struct i2c_client *client = to_i2c_client(dev);
struct w83795_data *data = i2c_get_clientdata(client);
struct w83795_data *data = dev_get_drvdata(dev);
long temp = temp_from_reg(data->dts_ext[nr]);

return sprintf(buf, "%ld\n", temp);
Expand Down Expand Up @@ -1328,8 +1326,7 @@ store_dts_ext(struct device *dev, struct device_attribute *attr,
static ssize_t
show_temp_mode(struct device *dev, struct device_attribute *attr, char *buf)
{
struct i2c_client *client = to_i2c_client(dev);
struct w83795_data *data = i2c_get_clientdata(client);
struct w83795_data *data = dev_get_drvdata(dev);
struct sensor_device_attribute_2 *sensor_attr =
to_sensor_dev_attr_2(attr);
int index = sensor_attr->index;
Expand Down

0 comments on commit 21fc977

Please sign in to comment.