Skip to content

Commit

Permalink
cfg80211: fix refcount leak
Browse files Browse the repository at this point in the history
The code in cfg80211's cfg80211_bss_update erroneously
grabs a reference to the BSS, which means that it will
never be freed.

Signed-off-by: Johannes Berg <[email protected]>
Cc: [email protected] [2.6.29, 2.6.30]
Signed-off-by: John W. Linville <[email protected]>
  • Loading branch information
jmberg authored and linvjw committed Jul 7, 2009
1 parent 76d8b64 commit 2dce4c2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion net/wireless/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@ cfg80211_bss_update(struct cfg80211_registered_device *dev,
found = rb_find_bss(dev, res);

if (found) {
kref_get(&found->ref);
found->pub.beacon_interval = res->pub.beacon_interval;
found->pub.tsf = res->pub.tsf;
found->pub.signal = res->pub.signal;
Expand Down

0 comments on commit 2dce4c2

Please sign in to comment.