Skip to content

Commit

Permalink
ftrace: Do not pass data to ftrace_dyn_arch_init
Browse files Browse the repository at this point in the history
As the data parameter is not really used by any ftrace_dyn_arch_init,
remove that from ftrace_dyn_arch_init. This also removes the addr
local variable from ftrace_init which is now unused.

Note the documentation was imprecise as it did not suggest to set
(*data) to 0.

Link: http://lkml.kernel.org/r/[email protected]

Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: [email protected]
Signed-off-by: Jiri Slaby <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
  • Loading branch information
Jiri Slaby authored and rostedt committed Mar 7, 2014
1 parent af64a7c commit 3a36cb1
Show file tree
Hide file tree
Showing 15 changed files with 16 additions and 19 deletions.
2 changes: 1 addition & 1 deletion Documentation/trace/ftrace-design.txt
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ Every arch has an init callback function. If you need to do something early on
to initialize some state, this is the time to do that. Otherwise, this simple
function below should be sufficient for most people:

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ int ftrace_make_nop(struct module *mod,
return ret;
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/blackfin/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ int ftrace_update_ftrace_func(ftrace_func_t func)
return ftrace_modify_code(ip, call, sizeof(call));
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/ia64/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ int ftrace_update_ftrace_func(ftrace_func_t func)
}

/* run from kstop_machine */
int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
2 changes: 1 addition & 1 deletion arch/metag/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ int ftrace_make_call(struct dyn_ftrace *rec, unsigned long addr)
}

/* run from kstop_machine */
int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
2 changes: 1 addition & 1 deletion arch/microblaze/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ int ftrace_make_call(struct dyn_ftrace *rec, unsigned long addr)
return ret;
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/mips/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ int ftrace_update_ftrace_func(ftrace_func_t func)
return ftrace_modify_code(FTRACE_CALL_IP, new);
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
/* Encode the instructions when booting */
ftrace_dyn_arch_init_insns();
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ void arch_ftrace_update_code(int command)
ftrace_disable_ftrace_graph_caller();
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/s390/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ int ftrace_update_ftrace_func(ftrace_func_t func)
return 0;
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/sh/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ int ftrace_make_call(struct dyn_ftrace *rec, unsigned long addr)
return ftrace_modify_code(rec->ip, old, new);
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ int ftrace_update_ftrace_func(ftrace_func_t func)
return ftrace_modify_code(ip, old, new);
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/tile/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ int ftrace_make_nop(struct module *mod,
return ret;
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/kernel/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ void arch_ftrace_update_code(int command)
atomic_dec(&modifying_ftrace_code);
}

int __init ftrace_dyn_arch_init(void *data)
int __init ftrace_dyn_arch_init(void)
{
return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion include/linux/ftrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ ftrace_set_early_filter(struct ftrace_ops *ops, char *buf, int enable);

/* defined in arch */
extern int ftrace_ip_converted(unsigned long ip);
extern int ftrace_dyn_arch_init(void *data);
extern int ftrace_dyn_arch_init(void);
extern void ftrace_replace_code(int enable);
extern int ftrace_update_ftrace_func(ftrace_func_t func);
extern void ftrace_caller(void);
Expand Down
7 changes: 2 additions & 5 deletions kernel/trace/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -4372,14 +4372,11 @@ void __init ftrace_init(void)
{
extern unsigned long __start_mcount_loc[];
extern unsigned long __stop_mcount_loc[];
unsigned long count, addr, flags;
unsigned long count, flags;
int ret;

/* Keep the ftrace pointer to the stub */
addr = (unsigned long)ftrace_stub;

local_irq_save(flags);
ret = ftrace_dyn_arch_init(&addr);
ret = ftrace_dyn_arch_init();
local_irq_restore(flags);
if (ret)
goto failed;
Expand Down

0 comments on commit 3a36cb1

Please sign in to comment.