Skip to content

Commit

Permalink
caif_usb: Make the driver name check more efficient
Browse files Browse the repository at this point in the history
Use the device model to get just the name, rather than using the
ethtool API to get all driver information.

Signed-off-by: Ben Hutchings <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Ben Hutchings authored and davem330 committed Dec 9, 2012
1 parent 4066363 commit 65d2897
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions net/caif/caif_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,10 @@ static int cfusbl_device_notify(struct notifier_block *me, unsigned long what,
struct cflayer *layer, *link_support;
struct usbnet *usbnet;
struct usb_device *usbdev;
struct ethtool_drvinfo drvinfo;

/*
* Quirks: High-jack ethtool to find if we have a NCM device,
* and find it's VID/PID.
*/
if (dev->ethtool_ops == NULL || dev->ethtool_ops->get_drvinfo == NULL)
return 0;

dev->ethtool_ops->get_drvinfo(dev, &drvinfo);
if (strncmp(drvinfo.driver, "cdc_ncm", 7) != 0)
/* Check whether we have a NCM device, and find its VID/PID. */
if (!(dev->dev.parent && dev->dev.parent->driver &&
strcmp(dev->dev.parent->driver->name, "cdc_ncm") == 0))
return 0;

usbnet = netdev_priv(dev);
Expand Down

0 comments on commit 65d2897

Please sign in to comment.