Skip to content

Commit

Permalink
cw1200: Remove useless return variables
Browse files Browse the repository at this point in the history
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
    when strict
return
- ret
+ C
;
// </smpl>

Signed-off-by: Peter Senna Tschudin <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
  • Loading branch information
petersenna authored and linvjw committed Jun 19, 2014
1 parent 12f3237 commit 69253b6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/net/wireless/cw1200/sta.c
Original file line number Diff line number Diff line change
Expand Up @@ -2289,7 +2289,6 @@ static int cw1200_upload_null(struct cw1200_common *priv)

static int cw1200_upload_qosnull(struct cw1200_common *priv)
{
int ret = 0;
/* TODO: This needs to be implemented
struct wsm_template_frame frame = {
Expand All @@ -2306,7 +2305,7 @@ static int cw1200_upload_qosnull(struct cw1200_common *priv)
dev_kfree_skb(frame.skb);
*/
return ret;
return 0;
}

static int cw1200_enable_beaconing(struct cw1200_common *priv,
Expand Down

0 comments on commit 69253b6

Please sign in to comment.