Skip to content

Commit

Permalink
ALSA: move snd_powermac's probe function to .devinit.text
Browse files Browse the repository at this point in the history
A pointer to snd_pmac_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (when having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <[email protected]>
Cc: Jaroslav Kysela <[email protected]>
Cc: Johannes Berg <[email protected]>
Cc: Rene Herman <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
Uwe Kleine-König authored and tiwai committed Apr 6, 2009
1 parent 0221c81 commit 7d2ac10
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/ppc/powermac.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ static struct platform_device *device;
/*
*/

static int __init snd_pmac_probe(struct platform_device *devptr)
static int __devinit snd_pmac_probe(struct platform_device *devptr)
{
struct snd_card *card;
struct snd_pmac *chip;
Expand Down

0 comments on commit 7d2ac10

Please sign in to comment.