Skip to content

Commit

Permalink
Drivers: edac: remove __dev* attributes.
Browse files Browse the repository at this point in the history
CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, and __devexit
from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton <[email protected]>
Cc: Doug Thompson <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Mark Gross <[email protected]>
Cc: Jason Uhlenkott <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Tim Small <[email protected]>
Cc: Ranganathan Desikan <[email protected]>
Cc: "Arvind R." <[email protected]>
Cc: Ralf Baechle <[email protected]>
Cc: David Daney <[email protected]>
Cc: Egor Martovetsky <[email protected]>
Cc: Olof Johansson <[email protected]>
Cc: Chris Metcalf <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Jan 3, 2013
1 parent 312faca commit 9b3c6e8
Show file tree
Hide file tree
Showing 31 changed files with 111 additions and 128 deletions.
8 changes: 4 additions & 4 deletions drivers/edac/amd64_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2563,8 +2563,8 @@ static int amd64_init_one_instance(struct pci_dev *F2)
return ret;
}

static int __devinit amd64_probe_one_instance(struct pci_dev *pdev,
const struct pci_device_id *mc_type)
static int amd64_probe_one_instance(struct pci_dev *pdev,
const struct pci_device_id *mc_type)
{
u8 nid = get_node_id(pdev);
struct pci_dev *F3 = node_to_amd_nb(nid)->misc;
Expand Down Expand Up @@ -2612,7 +2612,7 @@ static int __devinit amd64_probe_one_instance(struct pci_dev *pdev,
return ret;
}

static void __devexit amd64_remove_one_instance(struct pci_dev *pdev)
static void amd64_remove_one_instance(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;
struct amd64_pvt *pvt;
Expand Down Expand Up @@ -2686,7 +2686,7 @@ MODULE_DEVICE_TABLE(pci, amd64_pci_table);
static struct pci_driver amd64_pci_driver = {
.name = EDAC_MOD_STR,
.probe = amd64_probe_one_instance,
.remove = __devexit_p(amd64_remove_one_instance),
.remove = amd64_remove_one_instance,
.id_table = amd64_pci_table,
};

Expand Down
8 changes: 4 additions & 4 deletions drivers/edac/amd76x_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ static int amd76x_probe1(struct pci_dev *pdev, int dev_idx)
}

/* returns count (>= 0), or negative on error */
static int __devinit amd76x_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
static int amd76x_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
{
edac_dbg(0, "\n");

Expand All @@ -318,7 +318,7 @@ static int __devinit amd76x_init_one(struct pci_dev *pdev,
* structure for the device then delete the mci and free the
* resources.
*/
static void __devexit amd76x_remove_one(struct pci_dev *pdev)
static void amd76x_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;

Expand Down Expand Up @@ -350,7 +350,7 @@ MODULE_DEVICE_TABLE(pci, amd76x_pci_tbl);
static struct pci_driver amd76x_driver = {
.name = EDAC_MOD_STR,
.probe = amd76x_init_one,
.remove = __devexit_p(amd76x_remove_one),
.remove = amd76x_remove_one,
.id_table = amd76x_pci_tbl,
};

Expand Down
8 changes: 4 additions & 4 deletions drivers/edac/cell_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static void cell_edac_check(struct mem_ctl_info *mci)
}
}

static void __devinit cell_edac_init_csrows(struct mem_ctl_info *mci)
static void cell_edac_init_csrows(struct mem_ctl_info *mci)
{
struct csrow_info *csrow = mci->csrows[0];
struct dimm_info *dimm;
Expand Down Expand Up @@ -164,7 +164,7 @@ static void __devinit cell_edac_init_csrows(struct mem_ctl_info *mci)
}
}

static int __devinit cell_edac_probe(struct platform_device *pdev)
static int cell_edac_probe(struct platform_device *pdev)
{
struct cbe_mic_tm_regs __iomem *regs;
struct mem_ctl_info *mci;
Expand Down Expand Up @@ -233,7 +233,7 @@ static int __devinit cell_edac_probe(struct platform_device *pdev)
return 0;
}

static int __devexit cell_edac_remove(struct platform_device *pdev)
static int cell_edac_remove(struct platform_device *pdev)
{
struct mem_ctl_info *mci = edac_mc_del_mc(&pdev->dev);
if (mci)
Expand All @@ -247,7 +247,7 @@ static struct platform_driver cell_edac_driver = {
.owner = THIS_MODULE,
},
.probe = cell_edac_probe,
.remove = __devexit_p(cell_edac_remove),
.remove = cell_edac_remove,
};

static int __init cell_edac_init(void)
Expand Down
2 changes: 1 addition & 1 deletion drivers/edac/cpc925_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ static int cpc925_mc_get_channels(void __iomem *vbase)
return dual;
}

static int __devinit cpc925_probe(struct platform_device *pdev)
static int cpc925_probe(struct platform_device *pdev)
{
static int edac_mc_idx;
struct mem_ctl_info *mci;
Expand Down
7 changes: 3 additions & 4 deletions drivers/edac/e752x_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1390,8 +1390,7 @@ static int e752x_probe1(struct pci_dev *pdev, int dev_idx)
}

/* returns count (>= 0), or negative on error */
static int __devinit e752x_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
static int e752x_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
edac_dbg(0, "\n");

Expand All @@ -1402,7 +1401,7 @@ static int __devinit e752x_init_one(struct pci_dev *pdev,
return e752x_probe1(pdev, ent->driver_data);
}

static void __devexit e752x_remove_one(struct pci_dev *pdev)
static void e752x_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;
struct e752x_pvt *pvt;
Expand Down Expand Up @@ -1445,7 +1444,7 @@ MODULE_DEVICE_TABLE(pci, e752x_pci_tbl);
static struct pci_driver e752x_driver = {
.name = EDAC_MOD_STR,
.probe = e752x_init_one,
.remove = __devexit_p(e752x_remove_one),
.remove = e752x_remove_one,
.id_table = e752x_pci_tbl,
};

Expand Down
7 changes: 3 additions & 4 deletions drivers/edac/e7xxx_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,7 @@ static int e7xxx_probe1(struct pci_dev *pdev, int dev_idx)
}

/* returns count (>= 0), or negative on error */
static int __devinit e7xxx_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
static int e7xxx_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
edac_dbg(0, "\n");

Expand All @@ -538,7 +537,7 @@ static int __devinit e7xxx_init_one(struct pci_dev *pdev,
-EIO : e7xxx_probe1(pdev, ent->driver_data);
}

static void __devexit e7xxx_remove_one(struct pci_dev *pdev)
static void e7xxx_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;
struct e7xxx_pvt *pvt;
Expand Down Expand Up @@ -579,7 +578,7 @@ MODULE_DEVICE_TABLE(pci, e7xxx_pci_tbl);
static struct pci_driver e7xxx_driver = {
.name = EDAC_MOD_STR,
.probe = e7xxx_init_one,
.remove = __devexit_p(e7xxx_remove_one),
.remove = e7xxx_remove_one,
.id_table = e7xxx_pci_tbl,
};

Expand Down
2 changes: 1 addition & 1 deletion drivers/edac/highbank_l2_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ static irqreturn_t highbank_l2_err_handler(int irq, void *dev_id)
return IRQ_HANDLED;
}

static int __devinit highbank_l2_err_probe(struct platform_device *pdev)
static int highbank_l2_err_probe(struct platform_device *pdev)
{
struct edac_device_ctl_info *dci;
struct hb_l2_drvdata *drvdata;
Expand Down
6 changes: 3 additions & 3 deletions drivers/edac/highbank_mc_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,19 @@ static const struct file_operations highbank_mc_debug_inject_fops = {
.llseek = generic_file_llseek,
};

static void __devinit highbank_mc_create_debugfs_nodes(struct mem_ctl_info *mci)
static void highbank_mc_create_debugfs_nodes(struct mem_ctl_info *mci)
{
if (mci->debugfs)
debugfs_create_file("inject_ctrl", S_IWUSR, mci->debugfs, mci,
&highbank_mc_debug_inject_fops);
;
}
#else
static void __devinit highbank_mc_create_debugfs_nodes(struct mem_ctl_info *mci)
static void highbank_mc_create_debugfs_nodes(struct mem_ctl_info *mci)
{}
#endif

static int __devinit highbank_mc_probe(struct platform_device *pdev)
static int highbank_mc_probe(struct platform_device *pdev)
{
struct edac_mc_layer layers[2];
struct mem_ctl_info *mci;
Expand Down
7 changes: 3 additions & 4 deletions drivers/edac/i3000_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,7 @@ static int i3000_probe1(struct pci_dev *pdev, int dev_idx)
}

/* returns count (>= 0), or negative on error */
static int __devinit i3000_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
static int i3000_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
int rc;

Expand All @@ -472,7 +471,7 @@ static int __devinit i3000_init_one(struct pci_dev *pdev,
return rc;
}

static void __devexit i3000_remove_one(struct pci_dev *pdev)
static void i3000_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;

Expand Down Expand Up @@ -502,7 +501,7 @@ MODULE_DEVICE_TABLE(pci, i3000_pci_tbl);
static struct pci_driver i3000_driver = {
.name = EDAC_MOD_STR,
.probe = i3000_init_one,
.remove = __devexit_p(i3000_remove_one),
.remove = i3000_remove_one,
.id_table = i3000_pci_tbl,
};

Expand Down
7 changes: 3 additions & 4 deletions drivers/edac/i3200_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,8 +419,7 @@ static int i3200_probe1(struct pci_dev *pdev, int dev_idx)
return rc;
}

static int __devinit i3200_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
static int i3200_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
int rc;

Expand All @@ -436,7 +435,7 @@ static int __devinit i3200_init_one(struct pci_dev *pdev,
return rc;
}

static void __devexit i3200_remove_one(struct pci_dev *pdev)
static void i3200_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;
struct i3200_priv *priv;
Expand Down Expand Up @@ -467,7 +466,7 @@ MODULE_DEVICE_TABLE(pci, i3200_pci_tbl);
static struct pci_driver i3200_driver = {
.name = EDAC_MOD_STR,
.probe = i3200_init_one,
.remove = __devexit_p(i3200_remove_one),
.remove = i3200_remove_one,
.id_table = i3200_pci_tbl,
};

Expand Down
7 changes: 3 additions & 4 deletions drivers/edac/i5000_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1489,8 +1489,7 @@ static int i5000_probe1(struct pci_dev *pdev, int dev_idx)
* negative on error
* count (>= 0)
*/
static int __devinit i5000_init_one(struct pci_dev *pdev,
const struct pci_device_id *id)
static int i5000_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
{
int rc;

Expand All @@ -1509,7 +1508,7 @@ static int __devinit i5000_init_one(struct pci_dev *pdev,
* i5000_remove_one destructor for one instance of device
*
*/
static void __devexit i5000_remove_one(struct pci_dev *pdev)
static void i5000_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;

Expand Down Expand Up @@ -1547,7 +1546,7 @@ MODULE_DEVICE_TABLE(pci, i5000_pci_tbl);
static struct pci_driver i5000_driver = {
.name = KBUILD_BASENAME,
.probe = i5000_init_one,
.remove = __devexit_p(i5000_remove_one),
.remove = i5000_remove_one,
.id_table = i5000_pci_tbl,
};

Expand Down
24 changes: 11 additions & 13 deletions drivers/edac/i5100_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -638,8 +638,7 @@ static struct pci_dev *pci_get_device_func(unsigned vendor,
return ret;
}

static unsigned long __devinit i5100_npages(struct mem_ctl_info *mci,
int csrow)
static unsigned long i5100_npages(struct mem_ctl_info *mci, int csrow)
{
struct i5100_priv *priv = mci->pvt_info;
const unsigned chan_rank = i5100_csrow_to_rank(mci, csrow);
Expand All @@ -660,7 +659,7 @@ static unsigned long __devinit i5100_npages(struct mem_ctl_info *mci,
((unsigned long long) (1ULL << addr_lines) / PAGE_SIZE);
}

static void __devinit i5100_init_mtr(struct mem_ctl_info *mci)
static void i5100_init_mtr(struct mem_ctl_info *mci)
{
struct i5100_priv *priv = mci->pvt_info;
struct pci_dev *mms[2] = { priv->ch0mm, priv->ch1mm };
Expand Down Expand Up @@ -732,7 +731,7 @@ static int i5100_read_spd_byte(const struct mem_ctl_info *mci,
* o not the only way to may chip selects to dimm slots
* o investigate if there is some way to obtain this map from the bios
*/
static void __devinit i5100_init_dimm_csmap(struct mem_ctl_info *mci)
static void i5100_init_dimm_csmap(struct mem_ctl_info *mci)
{
struct i5100_priv *priv = mci->pvt_info;
int i;
Expand Down Expand Up @@ -762,8 +761,8 @@ static void __devinit i5100_init_dimm_csmap(struct mem_ctl_info *mci)
}
}

static void __devinit i5100_init_dimm_layout(struct pci_dev *pdev,
struct mem_ctl_info *mci)
static void i5100_init_dimm_layout(struct pci_dev *pdev,
struct mem_ctl_info *mci)
{
struct i5100_priv *priv = mci->pvt_info;
int i;
Expand All @@ -784,8 +783,8 @@ static void __devinit i5100_init_dimm_layout(struct pci_dev *pdev,
i5100_init_dimm_csmap(mci);
}

static void __devinit i5100_init_interleaving(struct pci_dev *pdev,
struct mem_ctl_info *mci)
static void i5100_init_interleaving(struct pci_dev *pdev,
struct mem_ctl_info *mci)
{
u16 w;
u32 dw;
Expand Down Expand Up @@ -830,7 +829,7 @@ static void __devinit i5100_init_interleaving(struct pci_dev *pdev,
i5100_init_mtr(mci);
}

static void __devinit i5100_init_csrows(struct mem_ctl_info *mci)
static void i5100_init_csrows(struct mem_ctl_info *mci)
{
int i;
struct i5100_priv *priv = mci->pvt_info;
Expand Down Expand Up @@ -864,8 +863,7 @@ static void __devinit i5100_init_csrows(struct mem_ctl_info *mci)
}
}

static int __devinit i5100_init_one(struct pci_dev *pdev,
const struct pci_device_id *id)
static int i5100_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
{
int rc;
struct mem_ctl_info *mci;
Expand Down Expand Up @@ -1020,7 +1018,7 @@ static int __devinit i5100_init_one(struct pci_dev *pdev,
return ret;
}

static void __devexit i5100_remove_one(struct pci_dev *pdev)
static void i5100_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;
struct i5100_priv *priv;
Expand Down Expand Up @@ -1054,7 +1052,7 @@ MODULE_DEVICE_TABLE(pci, i5100_pci_tbl);
static struct pci_driver i5100_driver = {
.name = KBUILD_BASENAME,
.probe = i5100_init_one,
.remove = __devexit_p(i5100_remove_one),
.remove = i5100_remove_one,
.id_table = i5100_pci_tbl,
};

Expand Down
7 changes: 3 additions & 4 deletions drivers/edac/i5400_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -1373,8 +1373,7 @@ static int i5400_probe1(struct pci_dev *pdev, int dev_idx)
* negative on error
* count (>= 0)
*/
static int __devinit i5400_init_one(struct pci_dev *pdev,
const struct pci_device_id *id)
static int i5400_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
{
int rc;

Expand All @@ -1393,7 +1392,7 @@ static int __devinit i5400_init_one(struct pci_dev *pdev,
* i5400_remove_one destructor for one instance of device
*
*/
static void __devexit i5400_remove_one(struct pci_dev *pdev)
static void i5400_remove_one(struct pci_dev *pdev)
{
struct mem_ctl_info *mci;

Expand Down Expand Up @@ -1431,7 +1430,7 @@ MODULE_DEVICE_TABLE(pci, i5400_pci_tbl);
static struct pci_driver i5400_driver = {
.name = "i5400_edac",
.probe = i5400_init_one,
.remove = __devexit_p(i5400_remove_one),
.remove = i5400_remove_one,
.id_table = i5400_pci_tbl,
};

Expand Down
Loading

0 comments on commit 9b3c6e8

Please sign in to comment.