Smack: prevent revoke-subject from failing when unseen label is writt…

…en to it Special file /smack/revoke-subject will silently accept labels that are not present on the subject label list. Nothing has to be done for such labels, as there are no rules for them to revoke. Targeted for git://git.gitorious.org/smack-next/kernel.git Signed-off-by: Rafal Krypa <[email protected]>
rtvt123 · Mar 19, 2013 · d15d9fa · d15d9fa
1 parent 921f3ac
commit d15d9fa
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
@@ -2035,10 +2035,8 @@ static ssize_t smk_write_revoke_subj(struct file *file, const char __user *buf,
 	}
 
 	skp = smk_find_entry(cp);
-	if (skp == NULL) {
-		rc = -EINVAL;
+	if (skp == NULL)
 		goto free_out;
-	}
 
 	rule_list = &skp->smk_rules;
 	rule_lock = &skp->smk_rules_lock;