Skip to content

Commit

Permalink
include/linux/sched.h: don't use task->pid/tgid in same_thread_group/…
Browse files Browse the repository at this point in the history
…has_group_leader_pid

task_struct->pid/tgid should go away.

1. Change same_thread_group() to use task->signal for comparison.

2. Change has_group_leader_pid(task) to compare task_pid(task) with
   signal->leader_pid.

Signed-off-by: Oleg Nesterov <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Sergey Dyasly <[email protected]>
Reviewed-by: "Eric W. Biederman" <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
oleg-nesterov authored and torvalds committed Sep 11, 2013
1 parent 28e8be3 commit e1403b8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions include/linux/sched.h
Original file line number Diff line number Diff line change
Expand Up @@ -2169,15 +2169,15 @@ static inline bool thread_group_leader(struct task_struct *p)
* all we care about is that we have a task with the appropriate
* pid, we don't actually care if we have the right task.
*/
static inline int has_group_leader_pid(struct task_struct *p)
static inline bool has_group_leader_pid(struct task_struct *p)
{
return p->pid == p->tgid;
return task_pid(p) == p->signal->leader_pid;
}

static inline
int same_thread_group(struct task_struct *p1, struct task_struct *p2)
bool same_thread_group(struct task_struct *p1, struct task_struct *p2)
{
return p1->tgid == p2->tgid;
return p1->signal == p2->signal;
}

static inline struct task_struct *next_thread(const struct task_struct *p)
Expand Down

0 comments on commit e1403b8

Please sign in to comment.