Skip to content

Commit

Permalink
drm/radeon: remove discardable flag from radeon_gem_object_create
Browse files Browse the repository at this point in the history
Unused and unimplemented. Also fix specifying the
kernel flag incorrectly at one occasion.

Signed-off-by: Christian König <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>
  • Loading branch information
ChristianKoenigAMD authored and alexdeucher committed Aug 5, 2014
1 parent 4807c5a commit ed5cb43
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/radeon/radeon.h
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ int radeon_gem_init(struct radeon_device *rdev);
void radeon_gem_fini(struct radeon_device *rdev);
int radeon_gem_object_create(struct radeon_device *rdev, unsigned long size,
int alignment, int initial_domain,
u32 flags, bool discardable, bool kernel,
u32 flags, bool kernel,
struct drm_gem_object **obj);

int radeon_mode_dumb_create(struct drm_file *file_priv,
Expand Down
3 changes: 1 addition & 2 deletions drivers/gpu/drm/radeon/radeon_fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
aligned_size = ALIGN(size, PAGE_SIZE);
ret = radeon_gem_object_create(rdev, aligned_size, 0,
RADEON_GEM_DOMAIN_VRAM,
0, false, true,
&gobj);
0, true, &gobj);
if (ret) {
printk(KERN_ERR "failed to allocate framebuffer (%d)\n",
aligned_size);
Expand Down
7 changes: 3 additions & 4 deletions drivers/gpu/drm/radeon/radeon_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ void radeon_gem_object_free(struct drm_gem_object *gobj)

int radeon_gem_object_create(struct radeon_device *rdev, unsigned long size,
int alignment, int initial_domain,
u32 flags, bool discardable, bool kernel,
u32 flags, bool kernel,
struct drm_gem_object **obj)
{
struct radeon_bo *robj;
Expand Down Expand Up @@ -253,7 +253,7 @@ int radeon_gem_create_ioctl(struct drm_device *dev, void *data,
args->size = roundup(args->size, PAGE_SIZE);
r = radeon_gem_object_create(rdev, args->size, args->alignment,
args->initial_domain, args->flags,
false, false, &gobj);
false, &gobj);
if (r) {
up_read(&rdev->exclusive_lock);
r = radeon_gem_handle_lockup(rdev, r);
Expand Down Expand Up @@ -568,8 +568,7 @@ int radeon_mode_dumb_create(struct drm_file *file_priv,

r = radeon_gem_object_create(rdev, args->size, 0,
RADEON_GEM_DOMAIN_VRAM, 0,
false, ttm_bo_type_device,
&gobj);
false, &gobj);
if (r)
return -ENOMEM;

Expand Down

0 comments on commit ed5cb43

Please sign in to comment.