RDS: Clean up error handling in rds_cmsg_rdma_args

We don't need to set ret = 0 at the end -- it's initialized to 0. Also, don't increment s_send_rdma stat if we're exiting with an error. Signed-off-by: Andy Grover <[email protected]> Signed-off-by: David S. Miller <[email protected]>
rtvt123 · Oct 30, 2010 · f4a3fc0 · f4a3fc0
1 parent a09f69c
commit f4a3fc0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
@@ -664,13 +664,12 @@ int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm,
 	}
 	op->op_bytes = nr_bytes;
 
-	ret = 0;
 out:
 	kfree(pages);
 	if (ret)
 		rds_rdma_free_op(op);
-
-	rds_stats_inc(s_send_rdma);
+	else
+		rds_stats_inc(s_send_rdma);
 
 	return ret;
 }