Skip to content

Commit

Permalink
Merge tag 'upstream-3.13-rc1' of git://git.infradead.org/linux-ubifs
Browse files Browse the repository at this point in the history
Pull ubifs changes from Artem Bityutskiy:
 "Mostly fixes for the power cut emulation UBIFS mode, and only one
  functional change which fixes a return error code"

* tag 'upstream-3.13-rc1' of git://git.infradead.org/linux-ubifs:
  UBIFS: correct data corruption range
  UBIFS: fix return code
  UBIFS: remove unnecessary code in ubifs_garbage_collect
  • Loading branch information
torvalds committed Nov 13, 2013
2 parents a7fa20a + 58a4e23 commit fbe43ff
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
6 changes: 3 additions & 3 deletions fs/ubifs/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -2563,9 +2563,9 @@ static int corrupt_data(const struct ubifs_info *c, const void *buf,
unsigned int from, to, ffs = chance(1, 2);
unsigned char *p = (void *)buf;

from = prandom_u32() % (len + 1);
/* Corruption may only span one max. write unit */
to = min(len, ALIGN(from, c->max_write_size));
from = prandom_u32() % len;
/* Corruption span max to end of write unit */
to = min(len, ALIGN(from + 1, c->max_write_size));

ubifs_warn("filled bytes %u-%u with %s", from, to - 1,
ffs ? "0xFFs" : "random data");
Expand Down
3 changes: 1 addition & 2 deletions fs/ubifs/gc.c
Original file line number Diff line number Diff line change
Expand Up @@ -668,8 +668,7 @@ int ubifs_garbage_collect(struct ubifs_info *c, int anyway)
ubifs_assert(!wbuf->used);

for (i = 0; ; i++) {
int space_before = c->leb_size - wbuf->offs - wbuf->used;
int space_after;
int space_before, space_after;

cond_resched();

Expand Down
8 changes: 6 additions & 2 deletions fs/ubifs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1630,8 +1630,10 @@ static int ubifs_remount_rw(struct ubifs_info *c)
}

c->write_reserve_buf = kmalloc(COMPRESSED_DATA_NODE_BUF_SZ, GFP_KERNEL);
if (!c->write_reserve_buf)
if (!c->write_reserve_buf) {
err = -ENOMEM;
goto out;
}

err = ubifs_lpt_init(c, 0, 1);
if (err)
Expand Down Expand Up @@ -2064,8 +2066,10 @@ static int ubifs_fill_super(struct super_block *sb, void *data, int silent)
}

sb->s_root = d_make_root(root);
if (!sb->s_root)
if (!sb->s_root) {
err = -ENOMEM;
goto out_umount;
}

mutex_unlock(&c->umount_mutex);
return 0;
Expand Down

0 comments on commit fbe43ff

Please sign in to comment.