Skip to content

Commit

Permalink
nghttpx: Fix assertion failure on mruby send_info with HTTP/1 frontend
Browse files Browse the repository at this point in the history
  • Loading branch information
tatsuhiro-t committed Nov 15, 2018
1 parent f6644a9 commit 3c393dc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/shrpx_https_upstream.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 +1049,7 @@ int HttpsUpstream::on_downstream_header_complete(Downstream *downstream) {
auto &resp = downstream->response();
auto &balloc = downstream->get_block_allocator();
auto dconn = downstream->get_downstream_connection();
assert(dconn);
// dconn might be nullptr if this is non-final response from mruby.

if (downstream->get_non_final_response() &&
!downstream->supports_non_final_response()) {
Expand All @@ -1059,6 +1059,7 @@ int HttpsUpstream::on_downstream_header_complete(Downstream *downstream) {

#ifdef HAVE_MRUBY
if (!downstream->get_non_final_response()) {
assert(dconn);
const auto &group = dconn->get_downstream_addr_group();
if (group) {
const auto &dmruby_ctx = group->mruby_ctx;
Expand Down

0 comments on commit 3c393dc

Please sign in to comment.