Skip to content

Commit

Permalink
nghttpx: Fix broken trailing slash handling
Browse files Browse the repository at this point in the history
nghttpx allows a pattern with trailing slash to match a request path
without it.  Previously, under certain pattern registration, this does
not work.
  • Loading branch information
tatsuhiro-t committed Dec 9, 2018
1 parent 302abf1 commit f3f4084
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
14 changes: 14 additions & 0 deletions src/shrpx_router.cc
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,16 @@ const RNode *match_partial(bool *pattern_is_wildcard, const RNode *node,
return node;
}

// The last '/' handling, see below.
node = find_next_node(node, '/');
if (node != nullptr && node->index != -1 && node->len == 1) {
return node;
}

return nullptr;
}

// The last '/' handling, see below.
if (node->index != -1 && offset + n + 1 == node->len &&
node->s[node->len - 1] == '/') {
return node;
Expand Down Expand Up @@ -265,6 +272,13 @@ const RNode *match_partial(bool *pattern_is_wildcard, const RNode *node,
return node;
}

// The last '/' handling, see below.
node = find_next_node(node, '/');
if (node != nullptr && node->index != -1 && node->len == 1) {
*pattern_is_wildcard = false;
return node;
}

return found_node;
}

Expand Down
10 changes: 10 additions & 0 deletions src/shrpx_router_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ void test_shrpx_router_match(void) {
{StringRef::from_lit("www.nghttp2.org/alpha/"), 4},
{StringRef::from_lit("/alpha"), 5},
{StringRef::from_lit("example.com/alpha/"), 6},
{StringRef::from_lit("nghttp2.org/alpha/bravo2/"), 7},
{StringRef::from_lit("www2.nghttp2.org/alpha/"), 8},
{StringRef::from_lit("www2.nghttp2.org/alpha2/"), 9},
};

Router router;
Expand Down Expand Up @@ -84,6 +87,13 @@ void test_shrpx_router_match(void) {
idx = router.match(StringRef::from_lit("nghttp2.org"),
StringRef::from_lit("/alpha/bravo"));

CU_ASSERT(3 == idx);

idx = router.match(StringRef::from_lit("www2.nghttp2.org"),
StringRef::from_lit("/alpha"));

CU_ASSERT(8 == idx);

idx = router.match(StringRef{}, StringRef::from_lit("/alpha"));

CU_ASSERT(5 == idx);
Expand Down

0 comments on commit f3f4084

Please sign in to comment.