Define codeowners for microfrontend definitions (kyma-project#8450)

* define ownership for microfrontend definitions * define addon-ui image version in its own chart owned by ui devs Co-authored-by: Kwiatosz, Krzysztof <[email protected]>
ruanxin · May 15, 2020 · c0b990d · c0b990d
1 parent 851b170
commit c0b990d
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 11 deletions.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -82,21 +82,21 @@
 # The `helm-broker` subchart
 /resources/helm-broker/ @aszecowka @PK85 @mszostok @piotrmiskiewicz @polskikiel @ksputo @jasiu001 @adamwalach
 
+# The `addons-ui` subchart
+/resources/helm-broker/charts/addons-ui/ @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+
 # The `monitoring` subchart
 /resources/monitoring/ @a-thaler @hisarbalik @lilitgh @suleymanakbas91 @clebs @rakesh-garimella
 
 # The `kubeless` subchart
 /resources/core/charts/kubeless/ @joek @abbi-gaurav @lilitgh @k15r @nachtmaar @anishj0shi @montaro @marcobebway @radufa @sayanh @michal-hudy @m00g3n @aerfio @pPrecel @magicmatatjahu
 
 # The `lambda-ui` subchart
-/resources/core/charts/kubeless/charts/lambdas-ui/ @dariadomagala @akucharska @parostatkiem @Wawrzyn321  @kwiatekus @michal-hudy @m00g3n @aerfio @pPrecel @magicmatatjahu
+/resources/core/charts/kubeless/charts/lambdas-ui/ @michal-hudy @m00g3n @aerfio @pPrecel @magicmatatjahu
 
 # The `logging` subchart
 /resources/logging/ @a-thaler @hisarbalik @lilitgh @suleymanakbas91 @clebs @rakesh-garimella
 
-# The `log-ui` subchart
-/resources/logging/charts/log-ui/ @dariadomagala @akucharska @parostatkiem @Wawrzyn321  @kwiatekus
-
 # The `event-sources` chart
 /resources/event-sources/ @joek  @lilitgh @k15r @nachtmaar @anishj0shi @montaro @marcobebway @radufa @sayanh
 
@@ -163,9 +163,6 @@
 # The `api-gateway` chart
 /resources/api-gateway/ @piotrmsc @kubadz @strekm @jakkab @Tomasz-Smelcerz-SAP @Demonsthere
 
-# The `api-gateway ui` micro front-end 
-/resources/api-gateway/templates/api-rules-microfrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
-
 # The `compass` chart
 /resources/compass/ @PK85 @aszecowka @crabtree @pkosiec @kfurgol @tgorgol @dbadura @kjaksik @akgalwas @janmedrek @Szymongib @franpog859 @Maladie @rafalpotempa
 /resources/compass/values.yaml @PK85 @aszecowka @crabtree @pkosiec @kfurgol @tgorgol @dbadura @kjaksik @akgalwas @janmedrek @Szymongib @franpog859 @Maladie @mszostok @piotrmiskiewicz @polskikiel @ksputo @jasiu001 @rafalpotempa
@@ -392,3 +389,22 @@ milv.config.yaml @michal-hudy @m00g3n @aerfio @pPrecel @magicmatatjahu @kazydek
 
 # performance tests
 /tests/perf/ @a-thaler @hisarbalik @lilitgh @suleymanakbas91 @clebs @rakesh-garimella
+
+# The `api-gateway ui` micro front-end definition
+/resources/api-gateway/templates/api-rules-microfrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+
+# application ui microfrontend definitions
+/resources/application-connector/templates/applications-microfrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+
+# serverless ui microfrontend definitions
+/resources/serverless/templates/cluster-microfrontend-functions.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+
+# monitoring ui microfrontend definitions
+/resources/kiali/templates/kyma-additions/clustermicrofrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+/resources/logging/templates/log-ui/clustermicrofrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+/resources/monitoring/charts/grafana/templates/kyma-additions/stats-metrics-microfrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+/resources/tracing/templates/kyma-additions/microfrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+
+# compass ui microfrontend definitions
+/resources/compass/templates/compass-apps-microfrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
+/resources/compass-runtime-agent/templates/compass-apps-microfrontend.yaml @dariadomagala @parostatkiem @akucharska @Wawrzyn321 @kwiatekus
diff --git a/resources/helm-broker/charts/addons-ui/templates/deployment.yaml b/resources/helm-broker/charts/addons-ui/templates/deployment.yaml
@@ -23,7 +23,7 @@ spec:
     spec:
       containers:
         - name: {{ .Chart.Name }}
-          image: "{{ .Values.global.containerRegistry.path }}/{{ .Values.global.addons_ui.dir }}{{ .Values.image.name }}:{{ .Values.global.addons_ui.version }}"
+          image: "{{ .Values.global.containerRegistry.path }}/{{ .Values.image.name }}:{{ .Values.image.version }}"
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           ports:
           - containerPort: {{ .Values.service.internalPort }}

diff --git a/resources/helm-broker/charts/addons-ui/values.yaml b/resources/helm-broker/charts/addons-ui/values.yaml
@@ -3,6 +3,7 @@ replicaCount: 1
 image:
   name: add-ons-ui
   pullPolicy: IfNotPresent
+  version: "49294757"
 service:
   internalPort: 80
   externalPort: 80

diff --git a/resources/helm-broker/values.yaml b/resources/helm-broker/values.yaml
@@ -57,9 +57,6 @@ global:
   etcdClientPort: 2379
 
   # Additional values for sub-charts and extras
-  addons_ui:
-    dir:
-    version: "49294757"
   istio:
     gateway:
       name: kyma-gateway