Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activejob: Add types for ActiveJob::Logging #732

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+34 −9
Open

activejob: Add types for ActiveJob::Logging #732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
199f409
refactor(activejob): move ActiveJob::Logging from generated
sanfrecce-osaka Nov 25, 2024
9a5c8f8
feat(activejob): Add types for ActiveJob::Logging
sanfrecce-osaka Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(activejob): move ActiveJob::Logging from generated
  • Loading branch information
@sanfrecce-osaka
sanfrecce-osaka committed Nov 25, 2024
commit 199f4096daf65cdcac65bdba005354bc82108f21
9 changes: 0 additions & 9 deletions gems/activejob/6.0/activejob-generated.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,15 +630,6 @@ end

module ActiveJob
module Logging
# nodoc:
extend ActiveSupport::Concern

private

def tag_logger: (*untyped tags) { () -> untyped } -> untyped

def logger_tagged_by_active_job?: () -> untyped

class LogSubscriber < ActiveSupport::LogSubscriber
# nodoc:
def enqueue: (untyped event) -> untyped
Expand Down
13 changes: 13 additions & 0 deletions gems/activejob/6.0/activejob.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,16 @@ module ActiveJob
def self.discard_on: (*untyped) -> void | ...
end
end

module ActiveJob
module Logging
# nodoc:
extend ActiveSupport::Concern

private

def tag_logger: (*untyped tags) { () -> untyped } -> untyped

def logger_tagged_by_active_job?: () -> untyped
end
end