-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the shacl_validation
crate according to the refactoring of the core of rudof
#275
Draft
angelip2303
wants to merge
23
commits into
master
Choose a base branch
from
issue94
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
angelip2303
commented
Mar 3, 2025
•
edited
Loading
edited
- Use a template method in the constraint components traits
- Improve the naming / use of iterators in the FocusNodes and ValueNodes structs
- Improve the naming of the parameters to the shape validate method
- Remove the Debug + 'static constraints in the generics
- Improve how the constraint components are compiled
- Improve the implementation of the conversion to IriS for Constraint Components
- Improve the Validate Error
- Remove the store module, no longer needed
- Merge the NativeValidator and Validator traits
- Currently we have an expect in the FocusNodes implementation for CompiledShape
- Try replacing the fully-qualified syntax by something more concise
- Improve the checks for equality of the ValidationReport according to the SHACL recommendation
- Remove unnecessary SRDF helper
- Remove unnecessary clones
- Remove some unnecessary references in the parameters
- Constraint may raise an Error when evaluated, change the functions accordingly
- Replace the Deref thing in the constraints by something else, we are trying to emulate inheritance, and that is not idiomatic to Rust
- There's no need for having two validator traits
…e S: Query generic types by Q: Query
…of the constraint components
… Validation Reports and Validation Results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.