Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the shacl_validation crate according to the refactoring of the core of rudof #275

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

angelip2303
Copy link
Collaborator

@angelip2303 angelip2303 commented Mar 3, 2025

  • Use a template method in the constraint components traits
  • Improve the naming / use of iterators in the FocusNodes and ValueNodes structs
  • Improve the naming of the parameters to the shape validate method
  • Remove the Debug + 'static constraints in the generics
  • Improve how the constraint components are compiled
  • Improve the implementation of the conversion to IriS for Constraint Components
  • Improve the Validate Error
  • Remove the store module, no longer needed
  • Merge the NativeValidator and Validator traits
  • Currently we have an expect in the FocusNodes implementation for CompiledShape
  • Try replacing the fully-qualified syntax by something more concise
  • Improve the checks for equality of the ValidationReport according to the SHACL recommendation
  • Remove unnecessary SRDF helper
  • Remove unnecessary clones
  • Remove some unnecessary references in the parameters
  • Constraint may raise an Error when evaluated, change the functions accordingly
  • Replace the Deref thing in the constraints by something else, we are trying to emulate inheritance, and that is not idiomatic to Rust
  • There's no need for having two validator traits

@angelip2303 angelip2303 added this to the 0.2.0 milestone Mar 3, 2025
@angelip2303 angelip2303 self-assigned this Mar 3, 2025
@angelip2303 angelip2303 marked this pull request as draft March 3, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant