Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::time::Duration for time intervals #7616

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Use std::time::Duration for time intervals #7616

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec886e6
Merge branch 'master' into refactor/f64_to_duration higumachan 2 minu…
higumachan Aug 13, 2022
24fec7e
fix comments
higumachan Aug 13, 2022
18955ef
To confirm, I changed the Duration of SOUND from MILLI SECOND to Dura…
higumachan Jul 1, 2022
fed9f74
use round
higumachan Jul 1, 2022
9d9a863
replace other place f64 durations
higumachan Jul 3, 2022
36a7084
implement RuffleDuration base f64
higumachan Jul 28, 2022
5c3074b
Avoid using std::time::Duration as much as possible
higumachan Jul 28, 2022
baf4a79
fix clippy
higumachan Aug 13, 2022
a2e3bbf
cargo fmt
higumachan Aug 14, 2022
1ca43fa
rename RuffleDuration -> Duration
higumachan Sep 2, 2022
db26389
remove ordered_float dependencies
higumachan Sep 2, 2022
7e59e60
use +=
higumachan Sep 4, 2022
5b28725
fix review point
higumachan Sep 26, 2022
a98f3e2
chore: Fix the lockfile and a few source files that got screwed up in…
kmeisthax Nov 30, 2022
042ee49
core: Fix a handful of types that were added after this PR was origin…
kmeisthax Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix review point
  • Loading branch information
@higumachan @kmeisthax
higumachan authored and kmeisthax committed Nov 30, 2022
commit 5b2872566152e453bdfa0efbcb1b4c7461426939
4 changes: 2 additions & 2 deletions tests/tests/regression_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,7 @@ fn run_swf(
let base_path = Path::new(swf_path).parent().unwrap();
let mut executor = NullExecutor::new();
let movie = SwfMovie::from_path(swf_path, None)?;
let frame_time = Duration::from_millis(1000.0 / movie.frame_rate().to_f64());
let frame_time = Duration::from_secs(1.0 / movie.frame_rate().to_f64());
let trace_output = Rc::new(RefCell::new(Vec::new()));

#[allow(unused_mut)]
Expand Down Expand Up @@ -1447,7 +1447,7 @@ fn run_swf(
// with timer execution (timers will see an elapsed time of *at least*
// the requested timer interval).
if frame_time_sleep {
std::thread::sleep(StdDuration::from_nanos(frame_time.as_nanos() as u64));
std::thread::sleep(frame_time.into());
}

while !player
Expand Down