core: Propagate events to children in the reverse order #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when this is not an event type used by Buttons. Fixes ruffle-rs#8357.
|
Let's please add tests for this |
|
Is the issue with #7783 similar? |
adrian17
reviewed
Jan 26, 2023
| @@ -180,7 +180,12 @@ pub trait TInteractiveObject<'gc>: | |||
| ) -> ClipEventResult { | |||
| if event.propagates() { | |||
| if let Some(container) = self.as_displayobject().as_container() { | |||
| for child in container.iter_render_list() { | |||
| let children = if event.is_button_event() { | |||
| container.iter_render_list().collect::<Vec<_>>() | |||
There was a problem hiding this comment.
hmm, didn't look into correctness of this, but we definitely don't wanna allocate Vecs for this dynamically.
danielhjacobs
added
A-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when the event is not an event type used by Buttons.
Fixes #8357 (here's an edited version with traces that are now displayed in the correct order) while making sure it doesn't break the Fight mini-game in Zizzo Challenge. I haven't checked if this is also the correct behavior in AVM2 though.