Skip to content

Commit

Permalink
Git/Packet.pm: use 'if' instead of 'unless'
Browse files Browse the repository at this point in the history
The code is more understandable with 'if' instead of 'unless'.

Signed-off-by: Christian Couder <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
chriscool authored and gitster committed Nov 22, 2017
1 parent cb1c64b commit 4a54370
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions perl/Git/Packet.pm
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ sub packet_bin_read {

sub remove_final_lf_or_die {
my $buf = shift;
unless ( $buf =~ s/\n$// ) {
die "A non-binary line MUST be terminated by an LF.\n"
. "Received: '$buf'";
if ( $buf =~ s/\n$// ) {
return $buf;
}
return $buf;
die "A non-binary line MUST be terminated by an LF.\n"
. "Received: '$buf'";
}

sub packet_txt_read {
my ( $res, $buf ) = packet_bin_read();
unless ( $res == -1 or $buf eq '' ) {
if ( $res != -1 and $buf ne '' ) {
$buf = remove_final_lf_or_die($buf);
}
return ( $res, $buf );
Expand All @@ -91,10 +91,10 @@ sub packet_txt_read {
sub packet_key_val_read {
my ( $key ) = @_;
my ( $res, $buf ) = packet_txt_read();
unless ( $res == -1 or ( $buf =~ s/^$key=// and $buf ne '' ) ) {
die "bad $key: '$buf'";
if ( $res == -1 or ( $buf =~ s/^$key=// and $buf ne '' ) ) {
return ( $res, $buf );
}
return ( $res, $buf );
die "bad $key: '$buf'";
}

sub packet_bin_write {
Expand Down

0 comments on commit 4a54370

Please sign in to comment.