Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't let nginx drop api_key header" #51

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

kevjin
Copy link
Contributor

@kevjin kevjin commented Jan 31, 2021

Reverts #50 which broke CD:

Error: exit status 1
2021/01/31 22:24:50 [emerg] 531#531: "underscores_in_headers" directive is not allowed here in /tmp/nginx-cfg031801590:659
nginx: [emerg] "underscores_in_headers" directive is not allowed here in /tmp/nginx-cfg031801590:659
nginx: configuration file /tmp/nginx-cfg031801590 test failed

Instead of debugging what exactly is wrong, we can just pass "api-key" for now instead (thanks to @uadnan's suggestion)

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #51 (2180782) into main (f7ade54) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   63.52%   63.52%           
=======================================
  Files          21       21           
  Lines         680      680           
=======================================
  Hits          432      432           
  Misses        248      248           
Flag Coverage Δ
unittests 63.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ade54...3a3a14d. Read the comment docs.

@kevjin kevjin merged commit 46e038a into main Jan 31, 2021
@kevjin kevjin deleted the revert-50-kjin/api-key-pass branch February 8, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants