Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temp files #79

Merged
merged 4 commits into from
Feb 10, 2021
Merged

Remove temp files #79

merged 4 commits into from
Feb 10, 2021

Conversation

ankurd1
Copy link
Contributor

@ankurd1 ankurd1 commented Feb 10, 2021

  • Always use main.tf.json and delete it at the end
  • Removed the misc temp files and the --out option
  • Deleted the gen method

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #79 (d23bc6f) into main (5969c9e) will decrease coverage by 0.50%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   78.79%   78.29%   -0.51%     
==========================================
  Files          20       20              
  Lines         863      843      -20     
==========================================
- Hits          680      660      -20     
  Misses        183      183              
Flag Coverage Δ
unittests 78.29% <81.81%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/cli.py 71.09% <81.81%> (-3.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5969c9e...412fc8c. Read the comment docs.

Copy link
Contributor

@kevjin kevjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice DEBUG env var

@ankurd1 ankurd1 merged commit c8c0f8b into main Feb 10, 2021
@ankurd1 ankurd1 deleted the ankur/refactor branch February 10, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants